Date: Mon, 29 Jul 2013 19:58:29 +0200 From: =?utf-8?Q?Hans_Petter_Selasky?= <hans.petter.selasky@bitfrost.no> To: =?utf-8?Q?Warner_Losh?= <imp@bsdimp.com>, =?utf-8?Q?Adrian_Chadd?= <adrian@freebsd.org> Cc: =?utf-8?Q?freebsd-arm?= <freebsd-arm@freebsd.org>, =?utf-8?Q?freebsd-wireless=40freebsd=2Eorg?= <freebsd-wireless@freebsd.org> Subject: RE: My WLI-UC-GNM up crash Message-ID: <zarafa.51f6ad45.7961.536131947b8b1205@mail.lockless.no> In-Reply-To: <8AFE4FCA-BCAA-460C-ABFE-EC7FC2991B8C@bsdimp.com> References: <cakrd9exvuqeqz=3ntmh7k3e4_6fjw9jph_tpfchujhqhwwbzsg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,=0D=0A=0D=0AThe aligned will make sure that the structure gets padded = properly to the size specified. Only on ARM/MIPS etc, structures get auto= matically aligned according to the element in the structure requiring the= greatest alignment. I've test-compiled the USB WLAN drivers, and the ali= gned makes a difference. The problem is that the radiotap header skews so= me following elements, so that they are no longer aligned. The radiotap h= eader itself is packed, and this is not a problem.=0D=0A=0D=0A--HPS=0D=0A= =0D=0A=20=0D=0A-----Original message-----=0D=0A> From:Warner Losh <imp@bs= dimp.com <mailto:imp@bsdimp.com> >=0D=0A> Sent: Monday 29th July 2013 17:= 04=0D=0A> To: Adrian Chadd <adrian@freebsd.org <mailto:adrian@freebsd.org= > >=0D=0A> Cc: Hans Petter Selasky <hans.petter.selasky@bitfrost.no <mail= to:hans.petter.selasky@bitfrost.no> >; freebsd-arm <freebsd-arm@freebsd.o= rg <mailto:freebsd-arm@freebsd.org> >; freebsd-wireless@freebsd.org <mail= to:freebsd-wireless@freebsd.org>=20=0D=0A> Subject: Re: My WLI-UC-GNM up = crash=0D=0A>=20=0D=0A> Aren't structures already aligned to 4 bytes when = placed inside other structures (unless marked __packed)=3F=0D=0A>=20=0D=0A= > Warner=0D=0A>=20=0D=0A> On Jul 28, 2013, at 11:50 AM, Adrian Chadd wrot= e:=0D=0A>=20=0D=0A> > As long as that results in the radiotap structures = being 4 or 8 byte=0D=0A> > padded when it's embedded in the softc - then = yes, indeed.=0D=0A> >=20=0D=0A> > Xiao, can you try=3F=0D=0A> >=20=0D=0A>= >=20=0D=0A> > -adrian=0D=0A> >=20=0D=0A> > On 28 July 2013 03:35, Hans P= etter Selasky <hps@bitfrost.no <mailto:hps@bitfrost.no> > wrote:=0D=0A> >= > Hi,=0D=0A> >>=20=0D=0A> >> Can you try the attached patch=3F=0D=0A> >>=20= =0D=0A> >> --HPS=0D=0A> > _______________________________________________= =0D=0A> > freebsd-arm@freebsd.org <mailto:freebsd-arm@freebsd.org> maili= ng list=0D=0A> > http://lists.freebsd.org/mailman/listinfo/freebsd-arm <h= ttp://lists.freebsd.org/mailman/listinfo/freebsd-arm>=20=0D=0A> > To unsu= bscribe, send any mail to "freebsd-arm-unsubscribe@freebsd.org <mailto:fr= eebsd-arm-unsubscribe@freebsd.org> "=0D=0A>=20=0D=0A>=20=0D=0A=0D=0A From owner-freebsd-arm@FreeBSD.ORG Mon Jul 29 18:19:16 2013 Return-Path: <owner-freebsd-arm@FreeBSD.ORG> Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B75BB4A3 for <freebsd-arm@freebsd.org>; Mon, 29 Jul 2013 18:19:16 +0000 (UTC) (envelope-from hans.stimer@gmail.com) Received: from mail-pd0-x229.google.com (mail-pd0-x229.google.com [IPv6:2607:f8b0:400e:c02::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8FCD926B5 for <freebsd-arm@freebsd.org>; Mon, 29 Jul 2013 18:19:16 +0000 (UTC) Received: by mail-pd0-f169.google.com with SMTP id y11so227576pdj.14 for <freebsd-arm@freebsd.org>; Mon, 29 Jul 2013 11:19:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:message-id:in-reply-to:references:subject:x-mailer :mime-version:content-type; bh=dO4c3+0/zj/eZbkq65YpKV6LQeVnY4HBu2bdOTH7GNo=; b=a8qnu9hTt+D2RNk71WcIBudACVjg6wB8pVFvibLY5oZ5GYdTb4uRz4FQjA7V8yLhMn UFfCc0nkurXKGmCE7rARi70DMrTPQUvzTI9AS3n0/dOYG7RSVbvx7hLr6aLcVTFbLEfx YOrc4N8GZplsEkIUnuMvP7vdsMzhXeAMNIPPzHBwhiZgQSAzQhVSeGftqKmZ52K+ccvQ g/1KveQ5Hqc0LB+1iuUU8qgVlOatwhFq2tZrWlXWIDqOvdmSt5DLBnSpHM4Ue9+0plFt RorZqoaa7L9taeNzLVqCS1SWMDyAlxlrOStHahw1qC6PQW2zotIO4NpeHbSXw2SEyC7t TbUQ== X-Received: by 10.68.29.2 with SMTP id f2mr69623033pbh.184.1375121956161; Mon, 29 Jul 2013 11:19:16 -0700 (PDT) Received: from oli-mp51.local (70-90-170-37-ca.sfba.hfc.comcastbusiness.net. [70.90.170.37]) by mx.google.com with ESMTPSA id eq5sm78303612pbc.15.2013.07.29.11.19.14 for <freebsd-arm@freebsd.org> (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 29 Jul 2013 11:19:15 -0700 (PDT) Date: Mon, 29 Jul 2013 11:19:14 -0700 From: Hans Stimer <hans.stimer@gmail.com> To: <freebsd-arm@freebsd.org> Cc: Message-ID: <etPan.51f6b222.74b0dc51.2b7@oli-mp51.local> In-Reply-To: References: Subject: freebsd-arm-tools vs. crochet-freebsd X-Mailer: Airmail (183) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="51f6b222_19495cff_2b7" X-Content-Filtered-By: Mailman/MimeDel 2.1.14 X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor <freebsd-arm.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>, <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm>; List-Post: <mailto:freebsd-arm@freebsd.org> List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>, <mailto:freebsd-arm-request@freebsd.org?subject=subscribe> X-List-Received-Date: Mon, 29 Jul 2013 18:19:16 -0000 --51f6b222_19495cff_2b7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable What is the difference between freebsd-arm-tools and=C2=A0crochet-freebsd= =3F * Which one is becoming the standard solution for crossbuilding to ARM an= d creating images=3F * Is one =22blessed=22 to become part of the standard freebsd distributio= n=3F * Do they serve different needs=3F --51f6b222_19495cff_2b7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?zarafa.51f6ad45.7961.536131947b8b1205>