From owner-freebsd-stable@FreeBSD.ORG Sat Jul 1 20:19:38 2006 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0128416A403 for ; Sat, 1 Jul 2006 20:19:38 +0000 (UTC) (envelope-from mistry.7@osu.edu) Received: from mail.united-ware.com (am-productions.biz [69.61.164.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 806BB45367 for ; Sat, 1 Jul 2006 20:19:37 +0000 (GMT) (envelope-from mistry.7@osu.edu) Received: from [192.168.1.100] (am-productions.biz [69.61.164.22]) (authenticated bits=0) by mail.united-ware.com (8.13.6/8.13.6) with ESMTP id k61KPAH1056750 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 1 Jul 2006 16:25:17 -0400 (EDT) (envelope-from mistry.7@osu.edu) From: Anish Mistry To: freebsd-stable@freebsd.org Date: Sat, 1 Jul 2006 16:20:03 -0400 User-Agent: KMail/1.9.1 References: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4005420.eXet3BmkSX"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200607011620.18085.mistry.7@osu.edu> X-Spam-Status: No, score=-4.5 required=5.0 tests=ALL_TRUSTED,BAYES_60, MYFREEBSD2 autolearn=failed version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on mail.united-ware.com X-Virus-Scanned: ClamAV 0.88.2/1578/Fri Jun 30 05:34:32 2006 on mail.united-ware.com X-Virus-Status: Clean Cc: tbyte@otel.net Subject: Re: Bug in ata (ata-all.c) driver X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Jul 2006 20:19:38 -0000 --nextPart4005420.eXet3BmkSX Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Friday 30 June 2006 22:01, tbyte@otel.net wrote: > I found a little bug (probably) in sys/dev/ata-all.c which somehow > corrupts device parameters structure. When I first did "atacontrol > list" device info about ad0 looked like this: > Master: ad0 ATA/ATAPI revision 7 > after I ran "atacontrol cap ad0" it printed somewhat messy output > like having enabled SMART but not supported... > then I did "atacontrol list" again and saw that the line about ad0 > have changed to something like this: > Master: ad0 ATA/ATAPI revision 0 > or similar. > > After some digging and comparing the way "IOCATADEVICES" and > "IOCATAGPARM" work I saw (probably) bogus ata_getparam() call. > After removing this call to ata_getparam() everything work as > expected (atleast that's what it looks like for ~30 min run). > "atacontrol cap ad0" shows right results and doesn't screw the > device parameters. I just hope that this doesn't break something > else but I doubt it coz it just gets info and doesn't set anything. > > The "giant" patch is attached. It's agains today's -STABLE. Don't forget to open a PR for this issue, so it doesn't get lost. =2D-=20 Anish Mistry --nextPart4005420.eXet3BmkSX Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQBEptkCxqA5ziudZT0RAiPWAKDNdCp3tZBTkxAPTvm8hnm9sr+vkwCcDyCP Xtu3uHqlax3lgMaI+LDfqgg= =V727 -----END PGP SIGNATURE----- --nextPart4005420.eXet3BmkSX--