From nobody Mon Dec 12 14:41:31 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NW47v3hXwz4kX7m; Mon, 12 Dec 2022 14:41:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NW47v3JZ9z4LjG; Mon, 12 Dec 2022 14:41:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670856091; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TDeGlN4SjvEsHNNOP2oBCdsPUe/pGiEBo4glyBjwo/I=; b=R8JAVeH77MY8ZL3wyQg7udHD34A30J/psq056mjPUIXP2M3/AtL4UOD7oEVrU3vpgPmacv OomtCXcwBEtW7V40rCxgMIx2VDHrpAFiNP5LxlguqcFR8/xCua9KR4leSP7b0YWuhxmTco HVVz84hI1jR3j0dTgESyPFQiJa4sQrDtOqV/qajLWOQTRXBHDv42Tr0tpo+DhWSgG7T0V3 8ty8It2M8Lqf8GIqIW0h/FuH47l1UyEgWCCPzWYvmz8Sh7addF5F+Ys7BJu37WRhpOHvOX vQ2AtaMkeSiahtNJTA55yE+Xs+7nu1vgrYlmhwU4i8hOJbx87BdM3al0iudKZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670856091; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TDeGlN4SjvEsHNNOP2oBCdsPUe/pGiEBo4glyBjwo/I=; b=ehWyXMWzdvxQfgRTgGUW439O2cav8KHzJjebykgtpmeoqnzXCnQPqmMa2bZ3aKumALIIcj RdvuyAn7ItaSwLTP/KZgYJokk3k+FSaoqtWA1gip4dG8DwLUuUywb0ExiW7VG50kRTivIY 3uvjOLitL72lsLMBuwCsyxqcT8BKFXNQf9gNu/nCqWayNVsJkWGQ9LEWBgF6x563+v7kPt JOrjm/FLzDuQzMJhZ4X07j2gifP8/mc0hk1Ef3xhH0CQELCyy6N6+AYmm/XtDCGhj+gwtM VNAhIq/BO9n6R2IdoYAwmHHzgGsYOus/anXltYel4FW+mQjyRPoXLzJzZnNh5g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1670856091; a=rsa-sha256; cv=none; b=H5HVcY7LSC9rN24rGiJZIHS6wPQcskyyEn13QYJo4P3J5ETvCKDrvmng7Fo/3WpNeAvCqm yDYPJOUyJYuovPXo7uXaWfUJSHYmn9sZfpsLCwemhCfkAmwUy5KGrUjsF7Yy+HuiLi9J9S Xt6eZgMzuSB1f5Asx+e7KnVbfxiDYWQNmDU+74Wp0J52FZIU2O4ZAwTSg8MyXtvM1yfZY/ c8CNAghvlVzE6EZipfIo/M9xEhGwCxQ1tcO9kLJ2DqicMW3cBmb44ZxOIEakc7PE5NPXEf nPFiav6CPkoZ9aWy9agiMK1oqqZkX1y0L0CR4Lgb6vjeZjNKQS28EncJ7p0p0w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NW47v2M9VzcrP; Mon, 12 Dec 2022 14:41:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2BCEfVKn083883; Mon, 12 Dec 2022 14:41:31 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2BCEfVJH083881; Mon, 12 Dec 2022 14:41:31 GMT (envelope-from git) Date: Mon, 12 Dec 2022 14:41:31 GMT Message-Id: <202212121441.2BCEfVJH083881@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Cy Schubert Subject: git: 30584910c39f - stable/12 - heimdal: kadm5_c_get_principal() should check return code List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: 30584910c39f1a63ea594fe5c3a82cdf5d9ee40e Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=30584910c39f1a63ea594fe5c3a82cdf5d9ee40e commit 30584910c39f1a63ea594fe5c3a82cdf5d9ee40e Author: Cy Schubert AuthorDate: 2022-12-09 14:06:04 +0000 Commit: Cy Schubert CommitDate: 2022-12-12 14:41:21 +0000 heimdal: kadm5_c_get_principal() should check return code kadm5_c_get_principal() should check the return code from kadm5_ret_principal_ent(). As it doesn't it assumes success when there is none and can lead to potential vulnerability. Fix this. Reported by: rtm@csail.mit.edu (cherry picked from commit f6d5d31cd5d5b409851b3bf82c41a477a643a486) --- crypto/heimdal/lib/kadm5/get_c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/heimdal/lib/kadm5/get_c.c b/crypto/heimdal/lib/kadm5/get_c.c index 3c31a515b2f3..3cbfefdbf334 100644 --- a/crypto/heimdal/lib/kadm5/get_c.c +++ b/crypto/heimdal/lib/kadm5/get_c.c @@ -77,7 +77,7 @@ kadm5_c_get_principal(void *server_handle, ret = tmp; krb5_clear_error_message(context->context); if(ret == 0) - kadm5_ret_principal_ent(sp, out); + ret = kadm5_ret_principal_ent(sp, out); krb5_storage_free(sp); krb5_data_free (&reply); return ret;