From owner-cvs-src@FreeBSD.ORG Wed Mar 2 20:13:23 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3A45D16A4CF; Wed, 2 Mar 2005 20:13:23 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id CB11643D46; Wed, 2 Mar 2005 20:13:22 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id j22KDMvw082696; Wed, 2 Mar 2005 12:13:22 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.3/8.13.1/Submit) id j22KDMLW082694; Wed, 2 Mar 2005 12:13:22 -0800 (PST) (envelope-from obrien) Date: Wed, 2 Mar 2005 12:13:21 -0800 From: "David O'Brien" To: Scott Long Message-ID: <20050302201321.GB82598@dragon.nuxi.com> References: <200503021556.j22FugDk081853@repoman.freebsd.org> <4225E285.5000605@samsco.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4225E285.5000605@samsco.org> X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.8i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Scott Long cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/esp esp_sbus.c ncr53c9x.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2005 20:13:23 -0000 On Wed, Mar 02, 2005 at 08:57:57AM -0700, Scott Long wrote: > Scott Long wrote: > >scottl 2005-03-02 15:56:42 UTC > > FreeBSD src repository > > Modified files: > > sys/dev/esp esp_sbus.c ncr53c9x.c > > Log: > > The existing locking in the esp driver appears to be fairly adequate, so > > set the interrupt handler to be INTR_MPSAFE now that xpt_done() can be > > called without Giant. Giant is still on the top half of the driver and > > the timeout handlers. > > > > Revision Changes Path > > 1.9 +1 -1 src/sys/dev/esp/esp_sbus.c > > 1.8 +0 -2 src/sys/dev/esp/ncr53c9x.c > > My Ultra2 now has no [GIANT-LOCKED] messages at all during boot and > seems to run without any problems. I haven't done any performance > measurements yet, and enabling mpsafevfs will probably negate most > improvements that this might have given, but it's a start. > > David O'brien: THIS IS NOT A FREEBSD 5.4 CANDIDATE. It's a shame that > I'll need to postfix all of my commits from now on with this message. No f*cking sh*t locking changes aren't MFC candidates. Is this now a personal cursade of yours to argue over any costmetic changes I make? -- -- David (obrien@FreeBSD.org)