From owner-freebsd-hackers@freebsd.org Sun Sep 30 10:26:16 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B701C10BB95C for ; Sun, 30 Sep 2018 10:26:16 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 536A17D2E0 for ; Sun, 30 Sep 2018 10:26:16 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id BF70521607 for ; Sun, 30 Sep 2018 06:26:15 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 30 Sep 2018 06:26:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yuripv.net; h= content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=J8Px75/fvpc6c9gC9wn+RA1+tVYQmmFAGr1PC0rH+TU=; b=GhoBItX2 mJ+3/hTh8RWXbTrbxawpFgs5tPoMVfMNF/SYesFtC8uDxTy5DI7iNniMydGiymiZ MSJ29j2bIfCJWqfXY/yzliS2yiOs3uOKavcAT9+qGhUR40kAFbSqNOUNPbphdPbR O8k6xilApcYzfT1Ma4oqW3sKFEAkh1iu1NRBXUXMKvDb5adXmHwAHdxV5E6r7OIW /DwBu6pfHdWk9ZBT9mFAvFtGMo+rkRTmU6Nryks0jOTy4+vOCHyyWXyLEDO1o/qF 6BS1FTJGsqrxZhuSHOF+jKhKzHMbWUcHTkVlLSm613WeUN52DYitEPuG4knwBGsF xMBHptoMcPOV/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=J8Px75/fvpc6c9gC9wn+RA1+tVYQm mFAGr1PC0rH+TU=; b=HocJVlMzlmLAdvi/neW2HsLhhDN33d+8dthcLltEVim9d XAhHA1ZdmyrJniJeVsvX/bXzvaL9rsehPuJRGjTLjeoeMub8GeE7Za4ZkiFofRN/ rJd3zCtaTrbxbuJ6M4fBkh3BXtWESz9cmb0wIBJkgKFh/j18wApx4Jk9wgysCMcZ tw26bcrvhfAHqyzMQ/OOvoicbyf9eW1TpITFbOIxpIYKej6CvE2ieBY2icRxpe4L YLirJyoOV1m9HvnXLPKMeSCDItRKZ6ydqbsktxqybEkYx0zRn+ilqwlm1umw30DY 30l5yGUCUC2u4L+CaH/JD1d4kKAMe7KCLAljf1V4Q== X-ME-Proxy: X-ME-Sender: Received: from [192.168.1.2] (unknown [85.175.16.0]) by mail.messagingengine.com (Postfix) with ESMTPA id EFC11102D7 for ; Sun, 30 Sep 2018 06:26:14 -0400 (EDT) To: freebsd-hackers@freebsd.org From: Yuri Pankov Subject: pw(8): review for PR 231649, 231653 Message-ID: <34d9e3cc-1b85-aca6-1dce-d75100e4f0fd@yuripv.net> Date: Sun, 30 Sep 2018 13:26:13 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Sep 2018 10:26:16 -0000 Hi, I have put the changes to fix the problem described in PR231649 (`pw useradd -D -w` not modifying the pw.conf) out for review: https://reviews.freebsd.org/D17299 It also contains the fix for PR231653 (pw not respecting the path specified via -V when writing pw.conf) in there to make the added test case actually work. TIA