From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Oct 16 13:40:21 2005 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E5DE16A420 for ; Sun, 16 Oct 2005 13:40:21 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id C4D9143D68 for ; Sun, 16 Oct 2005 13:40:18 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j9GDeHul039914 for ; Sun, 16 Oct 2005 13:40:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j9GDeHd8039913; Sun, 16 Oct 2005 13:40:17 GMT (envelope-from gnats) Resent-Date: Sun, 16 Oct 2005 13:40:17 GMT Resent-Message-Id: <200510161340.j9GDeHd8039913@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Simun Mikecin Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A526116A41F for ; Sun, 16 Oct 2005 13:34:59 +0000 (GMT) (envelope-from sime@data.home.hr) Received: from data.home.hr (dh79-11.xnet.hr [83.139.79.11]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4C9B943D46 for ; Sun, 16 Oct 2005 13:34:59 +0000 (GMT) (envelope-from sime@data.home.hr) Received: by data.home.hr (Postfix, from userid 34062) id 0D39860069; Sun, 16 Oct 2005 15:34:58 +0200 (CEST) Message-Id: <20051016133458.0D39860069@data.home.hr> Date: Sun, 16 Oct 2005 15:34:58 +0200 (CEST) From: Simun Mikecin To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: john@feith.com Subject: ports/87518: [fix] multimedia/pvr250: Does not build on amd64 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Simun Mikecin List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 13:40:21 -0000 >Number: 87518 >Category: ports >Synopsis: [fix] multimedia/pvr250: Does not build on amd64 >Confidential: no >Severity: critical >Priority: high >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Oct 16 13:40:16 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Simun Mikecin >Release: FreeBSD 6.0-RC1 amd64 >Organization: >Environment: System: FreeBSD data.home.hr 6.0-RC1 FreeBSD 6.0-RC1 #0: Sun Oct 16 05:22:12 CEST 2005 root@data:/var/obj/usr/src/sys/DATA amd64 >Description: On FreeBSD/amd64 bus_space_handle_t and bus_space_tag_t are defined as 64-bit (see sys/amd64/include/_bus.h). cxm_i2c.c calls BUS_READ_IVAR macro using 'unsigned int' (which is 32-bit on amd64) as the last parameter, where it should be bus_space_handle_t. On FreeBSD 6.x warning is emitted and compilation stops (6.x has implicit -Werror). Current multimedia/pvr250 port doesn't build on FreeBSD 6.x at all. That problem is already addressed in ports/85433 which is still not commited as of this writing. All testing was done with patches from that PR already applied. >How-To-Repeat: Try this on FreeBSD/amd64: cd /usr/ports/multimedia/pvr250 && make >Fix: --- cxm_i2c.c.orig Sun Oct 16 15:13:45 2005 +++ cxm_i2c.c Sun Oct 16 15:14:37 2005 @@ -156,8 +156,8 @@ int numkids; int i; int unit; - unsigned int bhandle; - unsigned int btag; + bus_space_handle_t bhandle; + bus_space_tag_t btag; struct cxm_iic_softc *sc; /* Get the device data */ >Release-Note: >Audit-Trail: >Unformatted: