From owner-svn-ports-head@FreeBSD.ORG  Sun Aug 11 15:28:15 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 4FA4D48D; Sun, 11 Aug 2013 15:28:15 +0000 (UTC)
Date: Sun, 11 Aug 2013 15:28:15 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Hajimu UMEMOTO <ume@FreeBSD.org>
Subject: Re: svn commit: r324593 - head/sysutils/gkrellm2
Message-ID: <20130811152815.GA35034@FreeBSD.org>
References: <201308111523.r7BFNpn0099666@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201308111523.r7BFNpn0099666@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Aug 2013 15:28:15 -0000

On Sun, Aug 11, 2013 at 03:23:51PM +0000, Hajimu UMEMOTO wrote:
> New Revision: 324593
> URL: http://svnweb.freebsd.org/changeset/ports/324593
> 
> @@ -14,8 +14,8 @@ COMMENT=	A GTK based system monitor

You could have dropped indefinite article from COMMENT while here.

>  LICENSE=	GPLv3
>  LICENSE_FILE=	${WRKSRC}/COPYING
>  
> +USES+=		gmake pkgconfig

Any reason to append to USES instead of simply assigning it?

> -Author:	Bill Wilson bill@gkrellm.net
> -WWW:    http://gkrellm.net
> +Author: Bill Wilson bill@gkrellm.net
> +WWW: http://gkrellm.net

We generally do not support listing author explicitly when there is WWW page
available.  You should have also terminated URL with a slash as advised by
PH, section 3.2.1.

./danfe