From nobody Thu Sep 18 22:42:46 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cSVyZ4DlTz688bs; Thu, 18 Sep 2025 22:42:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cSVyZ3Y6Vz3pqX; Thu, 18 Sep 2025 22:42:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758235366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+tBrvCw2rV5mbBB6g0ctE1fQlsFnFWyeadlIjiz7eR8=; b=juOcdXgt6lgpRC5QuSdbw4MRYBuNBV5y8vVh41f4CWkNRBJoeu5Gmt3TwDs7KNrMLj4Yxb NNM59NZrPwgwtzERBoYJEEy17/qh30Ec+BhmRkPPHtkF80+fZnM0wltr763pelOUxybw3z Lv6LrAdMKLF0mNBuQcXOfDDGeXY9KyiXAaLJapTb7yuYpzep/WpQGLLP3XTcMiNE6K/MuF HIzNMdvMedRZnghjWjuyD62XzNmZoVcS2OghwshmzEjvAVi3YUgn7LhQnIo7FB5F/sduq1 Sn7IoYcounXFF3Az4Qjl5qOwVUUvX57kzeveQDqhUeexdrjPJIxa8UA0OcP5fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758235366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+tBrvCw2rV5mbBB6g0ctE1fQlsFnFWyeadlIjiz7eR8=; b=okl21iy+w4h7ZkvefgjZEP09o2MXKPyBcUjIldHDHWMFHxFbRgHeQWpRQ6YvCzGNR4jnen 2j34ozE9Z7WQFFKZMh29a2NwuG6IYeGZxiqcyc2TodYua9R2IVGg2UDE7gLz8PIri+yW/8 Jh/8nJ14LUGQXLO13Zf/Ye1j2yGmjMmRHAthObTdBYu3iASSjmxSW2hF8/dA6ED6TX0pMN HyxN9CYFE7b+FJXmcCYr/lISERqfrlQsixFXSvUXb2rUQLAmjW39D2Jd4i76hJn+4zntnW q9qMYrg53wIsI88l2cycdBuua0/ru7weKiS4RY3Xqnm7EBAw4m159YGhIa7IXA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758235366; a=rsa-sha256; cv=none; b=k1fF0XV7Zqq9MCaRcuWjLCNsnUfrBCwgDhlI+EBfWw3VW0jaNr6Gb7viDFAkEjXVWQp0/w BqP0qIp8C8DY9M1iu+luU5bggJP2t59lm7Ogj1MtuSP1TuPOBmj/BW1JRcOIxzZGclb1B0 qa9qtu+B4rd17msquJCrdd5T+Xv9OgJ2resTbgLCCoN+swJGwbe0ZtAlsowtpaOfLU5MgO M+cqpod78nJo6/2FON9eAkXhbJ8SluGSxk6DnCfomE2ZYLUYFeg9x7x3RUAfQ90iqLzeoj JV9RH+p0uKYyPy3+dvoPOHae3HJnCXTKqbtLBjJjpkMAuH8XItqv/vBygY9vPA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cSVyZ2yYkzWqn; Thu, 18 Sep 2025 22:42:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58IMgkYh081713; Thu, 18 Sep 2025 22:42:46 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58IMgkNv081710; Thu, 18 Sep 2025 22:42:46 GMT (envelope-from git) Date: Thu, 18 Sep 2025 22:42:46 GMT Message-Id: <202509182242.58IMgkNv081710@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: daa63c9417a2 - main - pw: Print warnings when metadata updates fail List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: daa63c9417a28ad08881ff03df828fd8180dad12 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=daa63c9417a28ad08881ff03df828fd8180dad12 commit daa63c9417a28ad08881ff03df828fd8180dad12 Author: Mark Johnston AuthorDate: 2025-09-18 22:38:33 +0000 Commit: Mark Johnston CommitDate: 2025-09-18 22:38:33 +0000 pw: Print warnings when metadata updates fail We do this in most places already, but not consistently. MFC after: 1 week Sponsored by: The FreeBSD Foundation Sponsored by: Klara, Inc. --- usr.sbin/pw/cpdir.c | 6 ++++-- usr.sbin/pw/pw_user.c | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/usr.sbin/pw/cpdir.c b/usr.sbin/pw/cpdir.c index 3dee8f7c43ac..63068cab000c 100644 --- a/usr.sbin/pw/cpdir.c +++ b/usr.sbin/pw/cpdir.c @@ -127,8 +127,10 @@ copymkdir(int rootfd, char const * dir, int skelfd, mode_t mode, uid_t uid, /* * Propagate special filesystem flags */ - fchown(destfd, uid, gid); - fchflags(destfd, st.st_flags); + if (fchown(destfd, uid, gid) != 0) + warn("chown(%s)", p); + if (fchflags(destfd, st.st_flags) != 0) + warn("chflags(%s)", p); close(destfd); } closedir(d); diff --git a/usr.sbin/pw/pw_user.c b/usr.sbin/pw/pw_user.c index 8a9a4342f5ef..9f5cfb0f4473 100644 --- a/usr.sbin/pw/pw_user.c +++ b/usr.sbin/pw/pw_user.c @@ -123,7 +123,8 @@ mkdir_home_parents(int dfd, const char *dir) if (fstatat(dfd, dirs, &st, 0) == -1) { if (mkdirat(dfd, dirs, _DEF_DIRMODE) == -1) err(EX_OSFILE, "'%s' (home parent) is not a directory", dirs); - fchownat(dfd, dirs, 0, 0, 0); + if (fchownat(dfd, dirs, 0, 0, 0) != 0) + warn("chown(%s)", dirs); } free(dirs);