From owner-freebsd-current@FreeBSD.ORG Sun Mar 20 16:32:03 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A72201065670 for ; Sun, 20 Mar 2011 16:32:03 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 6A3468FC12 for ; Sun, 20 Mar 2011 16:32:03 +0000 (UTC) Received: from outgoing.leidinger.net (p5B154CFB.dip.t-dialin.net [91.21.76.251]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 5417A84400E; Sun, 20 Mar 2011 17:31:59 +0100 (CET) Received: from unknown (IO.Leidinger.net [192.168.2.110]) by outgoing.leidinger.net (Postfix) with ESMTP id A30BD3F8A; Sun, 20 Mar 2011 17:31:56 +0100 (CET) Date: Sun, 20 Mar 2011 17:31:57 +0100 From: Alexander Leidinger To: David Demelier Message-ID: <20110320173157.00002024@unknown> In-Reply-To: <4D85AE1B.7010407@gmail.com> References: <4D85AE1B.7010407@gmail.com> X-Mailer: Claws Mail 3.7.8cvs47 (GTK+ 2.16.6; i586-pc-mingw32msvc) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: 5417A84400E.A408F X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-0.923, required 6, autolearn=disabled, ALL_TRUSTED -1.00, TW_IB 0.08) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1301243520.51949@n/HUoipTR8ICo7W8i3SjFA X-EBL-Spam-Status: No Cc: freebsd-current@freebsd.org Subject: Re: WITHOUT_JAIL and make delete-old{,-libs} X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Mar 2011 16:32:03 -0000 On Sun, 20 Mar 2011 08:34:51 +0100 David Demelier wrote: > Hello, > > I was surprised to see there is no ${MK_JAIL} conditional to remove > old files on 8.2-RELEASE so I started to write it without watching if > -CURRENT already make it in > /usr/src/tools/build/mk/OptionalObsoleteFiles.inc. > > .if ${MK_JAIL} == no > OLD_FILES+=usr/sbin/jail > OLD_FILES+=usr/sbin/jexec > OLD_FILES+=usr/sbin/jls > OLD_FILES+=usr/share/man/man8/jail.8.gz > OLD_FILES+=usr/share/man/man8/jexec.8.gz > OLD_FILES+=usr/share/man/man8/jls.8.gz > .endif > > I personnaly added more files : > > OLD_LIBS+=lib/libjail.so.1 > OLD_LIBS+=usr/lib/libjail.a > OLD_LIBS+=usr/lib/libjail_p.a > OLD_FILES+=usr/lib/libjail.so > OLD_FILES+=etc/rc.d/jail So if you do an installworld, do those files you added show up again or not? If they show up, they are wrong to be added there. Delete old is supposed to delete stuff which does not get installed during an installworld but was installed in some older version of FreeBSD. From my reading of the Makefile in src/lib/ (on -current) it looks like at least the libjail is installed regardless of the knob. I do not know if this is a bug or by design, this would have to be discussed on the mailinglist which is about FreeBSD jails. If those files are not installed during an installworld, it's obviously a bug which needs to be fixed (and I would have misunderstood the Makefile). > (/usr/lib/libjail.so is a symbolic link) > > I think they should be removed too, thus can you merge it to -STABLE > if it's not already done? (sorry I'm not used to the cvs web > interface and I don't have -STABLE right now) > > Cheers, >