From owner-svn-src-all@freebsd.org Tue Apr 19 16:40:24 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7B1BBB13118; Tue, 19 Apr 2016 16:40:24 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ig0-x22e.google.com (mail-ig0-x22e.google.com [IPv6:2607:f8b0:4001:c05::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 474911FDA; Tue, 19 Apr 2016 16:40:24 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-ig0-x22e.google.com with SMTP id gy3so20591153igb.1; Tue, 19 Apr 2016 09:40:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=zUKoaFTA4VXEOsmI4SItbx1fRuYJOsmlLDDfVxswF3o=; b=fkd6zfD70BTA2GmVihvfzFcUhRPRdvqxb9Vrx+Hc773j/dJHUG1VXXZkEagP4mHClR lqgxNLWZh4e6PHedmI5hspqlQFqHFbow0he+U2mtbTJ19d+DYGXH544xK/ANy9EFHCFY cdb3MpU36FfyPLUdAH5NxCDv8GYEGetTUv01LIT/5/yvfOWxsf4XWcdHzxP3Mafm3TGY y1XjCASYpmso8dwxNkTsbKb+wRHC5cMpm/Gvf6OEeTEsoNl1e24QxZbAN/X+23T/LNOb b67xdpoUW4SIATyCFdBktJZWY9OvFBvQaQ6I1armZ2GlRBNvRBelXgTg58WhcZEkYbtg 9OHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=zUKoaFTA4VXEOsmI4SItbx1fRuYJOsmlLDDfVxswF3o=; b=VMJ60tdSr+zsifpfxlfq7sUg0pUJW5RitMK3U3z2NfSM6qN7jrN/rn45ygWBnPbNEj 3QDA6qe+ymKMKAFp2cvANaABGfETx7txDFNDN3s0LwxN3YDTWBk/YB4fV1Aj0Lg4tbkh ljb8+SIjEfDZoo8AcDUDEilns6d9sv4SkedNfb7DBEMKjwmxQtI+l8W+AmQlZGXDrhKo fE+GAsxsOf5o2CkFxh7zITuNR3VSC5VNcQKHzjeq2DNg1Hz7WWPRER+NuCQcwMeL/XJ9 Xkz9bNyUjsvBuaQALv20j40ASLpp3hchP8Fwf0igTkJbmySCsuYJuv8xVcyvUVMfQVzA aALg== X-Gm-Message-State: AOPr4FVqxf5mr3ku+cuv1YUtJtmPrC53gTlvHSxlxrAuWU99NGGX0UoZYPCkk9dpZUGgEx6EXacMUofJ4JFpVA== MIME-Version: 1.0 X-Received: by 10.50.50.234 with SMTP id f10mr26889312igo.37.1461084023630; Tue, 19 Apr 2016 09:40:23 -0700 (PDT) Received: by 10.36.14.19 with HTTP; Tue, 19 Apr 2016 09:40:23 -0700 (PDT) In-Reply-To: <201604191539.u3JFdkHx048678@repo.freebsd.org> References: <201604191539.u3JFdkHx048678@repo.freebsd.org> Date: Tue, 19 Apr 2016 09:40:23 -0700 Message-ID: Subject: Re: svn commit: r298274 - head/sys/dev/spibus From: Adrian Chadd To: Ruslan Bukin Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2016 16:40:24 -0000 Hm, why'd you do this? did you get it reviewed first? I'm about to write a kernel bitbang SPI driver that supports arbitrary GPIOs, and I was thinking of fleshing this out somewhat. -adrian On 19 April 2016 at 08:39, Ruslan Bukin wrote: > Author: br > Date: Tue Apr 19 15:39:46 2016 > New Revision: 298274 > URL: https://svnweb.freebsd.org/changeset/base/298274 > > Log: > Revert r298268 (Add optional chip_select/deselect methods). > None of supported hardware do require that. > > Modified: > head/sys/dev/spibus/spibus.c > head/sys/dev/spibus/spibus_if.m > > Modified: head/sys/dev/spibus/spibus.c > ============================================================================== > --- head/sys/dev/spibus/spibus.c Tue Apr 19 15:36:18 2016 (r298273) > +++ head/sys/dev/spibus/spibus.c Tue Apr 19 15:39:46 2016 (r298274) > @@ -185,24 +185,9 @@ spibus_hinted_child(device_t bus, const > static int > spibus_transfer_impl(device_t dev, device_t child, struct spi_command *cmd) > { > - > return (SPIBUS_TRANSFER(device_get_parent(dev), child, cmd)); > } > > -static int > -spibus_chip_select_impl(device_t dev, device_t child) > -{ > - > - return (SPIBUS_CHIP_SELECT(device_get_parent(dev), child)); > -} > - > -static int > -spibus_chip_deselect_impl(device_t dev, device_t child) > -{ > - > - return (SPIBUS_CHIP_DESELECT(device_get_parent(dev), child)); > -} > - > static device_method_t spibus_methods[] = { > /* Device interface */ > DEVMETHOD(device_probe, spibus_probe), > @@ -223,8 +208,6 @@ static device_method_t spibus_methods[] > > /* spibus interface */ > DEVMETHOD(spibus_transfer, spibus_transfer_impl), > - DEVMETHOD(spibus_chip_select, spibus_chip_select_impl), > - DEVMETHOD(spibus_chip_deselect, spibus_chip_deselect_impl), > > DEVMETHOD_END > }; > > Modified: head/sys/dev/spibus/spibus_if.m > ============================================================================== > --- head/sys/dev/spibus/spibus_if.m Tue Apr 19 15:36:18 2016 (r298273) > +++ head/sys/dev/spibus/spibus_if.m Tue Apr 19 15:39:46 2016 (r298274) > @@ -39,19 +39,3 @@ METHOD int transfer { > device_t child; > struct spi_command *cmd; > }; > - > -# > -# Assert chip select > -# > -METHOD int chip_select { > - device_t dev; > - device_t child; > -}; > - > -# > -# Deassert chip select > -# > -METHOD int chip_deselect { > - device_t dev; > - device_t child; > -}; >