From owner-svn-src-projects@freebsd.org Wed May 22 19:49:28 2019 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9C69915B5DBA for ; Wed, 22 May 2019 19:49:28 +0000 (UTC) (envelope-from asomers@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DAC5D95B55; Wed, 22 May 2019 19:49:27 +0000 (UTC) (envelope-from asomers@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 08EBF2215D; Wed, 22 May 2019 19:49:26 +0000 (UTC) (envelope-from asomers@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x4MJnP99045129; Wed, 22 May 2019 19:49:25 GMT (envelope-from asomers@FreeBSD.org) Received: (from asomers@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id x4MJnPpV045128; Wed, 22 May 2019 19:49:25 GMT (envelope-from asomers@FreeBSD.org) Message-Id: <201905221949.x4MJnPpV045128@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: asomers set sender to asomers@FreeBSD.org using -f From: Alan Somers Date: Wed, 22 May 2019 19:49:25 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r348119 - projects/fuse2/sys/fs/fuse X-SVN-Group: projects X-SVN-Commit-Author: asomers X-SVN-Commit-Paths: projects/fuse2/sys/fs/fuse X-SVN-Commit-Revision: 348119 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: DAC5D95B55 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.98)[-0.978,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 May 2019 19:49:28 -0000 Author: asomers Date: Wed May 22 19:49:25 2019 New Revision: 348119 URL: https://svnweb.freebsd.org/changeset/base/348119 Log: fusefs: remove the vfs.fusefs.sync_resize syctl, correctly this time In r347547 I intended to remove the vfs.fusefs.sync_resize sysctl, leaving fusefs's behavior as though sync_resize had its default value. But I forgot that I had already turned off sync_resize in my development system's /etc/sysctl.conf. This commit complete removes the optional behavior that was formerly controlled by sync_resize. There's no need for explicitly calling FUSE_SETATTR after every FUSE_WRITE that extends a file. The daemon can infer that the file is being extended. If this sysctl was added as a workaround for a buggy daemon, there's no clue as to what that daemon may have been. Sponsored by: The FreeBSD Foundation Modified: projects/fuse2/sys/fs/fuse/fuse_io.c Modified: projects/fuse2/sys/fs/fuse/fuse_io.c ============================================================================== --- projects/fuse2/sys/fs/fuse/fuse_io.c Wed May 22 19:39:55 2019 (r348118) +++ projects/fuse2/sys/fs/fuse/fuse_io.c Wed May 22 19:49:25 2019 (r348119) @@ -528,7 +528,6 @@ static int fuse_write_biobackend(struct vnode *vp, struct uio *uio, struct ucred *cred, struct fuse_filehandle *fufh, int ioflag, pid_t pid) { - struct fuse_vnode_data *fvdat = VTOFUD(vp); struct buf *bp; daddr_t lbn; off_t filesize; @@ -749,9 +748,6 @@ again: if (err) break; } while (uio->uio_resid > 0 && n > 0); - - if ((fvdat->flag & FN_SIZECHANGE) != 0) - fuse_vnode_savesize(vp, cred, pid); return (err); }