From owner-freebsd-current@FreeBSD.ORG Tue Apr 19 17:51:51 2011 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 739EE106566B; Tue, 19 Apr 2011 17:51:51 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net [IPv6:2001:7b8:2ff:146::2]) by mx1.freebsd.org (Postfix) with ESMTP id 323978FC0C; Tue, 19 Apr 2011 17:51:51 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7:0:7533:44c6:1935:7a72] (unknown [IPv6:2001:7b8:3a7:0:7533:44c6:1935:7a72]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 4CF035C59; Tue, 19 Apr 2011 19:51:49 +0200 (CEST) Message-ID: <4DADCBB4.8060301@FreeBSD.org> Date: Tue, 19 Apr 2011 19:51:48 +0200 From: Dimitry Andric Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.17) Gecko/20110415 Lanikai/3.1.11pre MIME-Version: 1.0 To: Alexander Leidinger References: <4DAC3FD9.1060603@FreeBSD.org> <20110418103416.76b07b36@kan.dnsalias.net> <4DAC9534.60009@FreeBSD.org> <20110419132114.43009vpwaeidet68@webmail.leidinger.net> In-Reply-To: <20110419132114.43009vpwaeidet68@webmail.leidinger.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "arch@freebsd.org" , "current@freebsd.org" Subject: Re: Removal of ICC (intel compiler) bits from mk X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2011 17:51:51 -0000 On 2011-04-19 13:21, Alexander Leidinger wrote: ... >>> You probably also want to remove the code that uses __INTEL_COMPILER >>> in source tree if you want to be really thorough. >> >> Ok, new patch attached. Some of the contributed sources also contain >> instances of __INTEL_COMPILER, but these are all from upstream, so I >> left them in. > > Is it really necessary to remove them from cdefs.h? If someone takes > parts of our source and wants to compile them on linux or windows with > icc, the icc parts in cdefs.h are a valuable part to have. Isn't that the case for the other headers too? Except the in_cksum.[ch] files, where the 'fix' for ICC is apparently not needed at all anymore. > Info: AFAIR I didn't add icc stuff to csup, and AFAIR csup was added > when our icc in the ports collection was outdated, so I assume someone > tested csup with icc on linux and addid this stuff there. Removing it > from csup seems to be a step backwards to me in this case. It used to be in contrib, but was moved to the base system recently. If csup is also ported to e.g. Linux, then it won't make much sense to remove the ICC ifdefs. > Regarding the build infrastructure part I just skimmed over it, and > the math/std* headers and 1s-complement-checksum part looks ok to me. For now, I will just commit the Makefile/*.mk part, and leave most headers as they are.