From owner-cvs-all@FreeBSD.ORG  Wed Jan  7 22:22:17 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1761E16A4CE; Wed,  7 Jan 2004 22:22:17 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2781643D31; Wed,  7 Jan 2004 22:22:16 -0800 (PST)
	(envelope-from truckman@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id i086MG0B095816;
	Wed, 7 Jan 2004 22:22:16 -0800 (PST)
	(envelope-from truckman@repoman.freebsd.org)
Received: (from truckman@localhost)
	by repoman.freebsd.org (8.12.10/8.12.10/Submit) id i086MFAX095815;
	Wed, 7 Jan 2004 22:22:15 -0800 (PST)
	(envelope-from truckman)
Message-Id: <200401080622.i086MFAX095815@repoman.freebsd.org>
From: Don Lewis <truckman@FreeBSD.org>
Date: Wed, 7 Jan 2004 22:22:15 -0800 (PST)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/pci if_dc.c if_dcreg.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Jan 2004 06:22:17 -0000

truckman    2004/01/07 22:22:15 PST

  FreeBSD src repository

  Modified files:
    sys/pci              if_dc.c if_dcreg.h 
  Log:
  The transmit frame status is stored in the last transmit descriptor for the
  frame, not the first.  It is probably also not safe to free the mbuf chain
  as soon as the OWN bit is cleared on the first descriptor since the chip
  may not be done copying the frame into the transmit FIFO.  Revert the part of
  of busdma conversion (if_dc.c rev 1.115) which changed dc_txeof() to look for
  the status in the first descriptor and free the mbuf chain when processing
  the first descriptor for the frame, and revert the matching changes elsewhere
  in the driver.  This part of the busdma change caused the driver to report
  spurious collisions and output errors, even when running in full-duplex mode.
  Reverting the mbuf chain handling slightly complicates dc_dma_map_txbuf(),
  since it is responsible for setting the OWN bits on the descriptors, but does
  not normally have direct access to the mbuf chain.
  
  Tested by:
    Dejan Lesjak <dejan.lesjak at ijs.si>  alpha/<Intel 21143 10/100BaseTX>
    "Xin LI" <delphij at frontfree.net>    i386/<Macronix 98713 10/100BaseTX>
    Wiktor Niesiobedzki <bsd at w.evip.pl> i386/<3Com OfficeConnect 10/100B>
  
  Reviewed by:    mux
  
  Revision  Changes    Path
  1.138     +4 -3      src/sys/pci/if_dc.c
  1.41      +1 -0      src/sys/pci/if_dcreg.h