From owner-cvs-src@FreeBSD.ORG  Mon Oct 23 22:47:06 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from localhost.my.domain (localhost [127.0.0.1])
	by hub.freebsd.org (Postfix) with ESMTP id 3B45D16A403;
	Mon, 23 Oct 2006 22:47:06 +0000 (UTC)
	(envelope-from davidxu@freebsd.org)
From: David Xu <davidxu@freebsd.org>
To: John Baldwin <jhb@freebsd.org>
Date: Tue, 24 Oct 2006 06:47:03 +0800
User-Agent: KMail/1.8.2
References: <200610212359.k9LNxF2P014387@repoman.freebsd.org>
	<200610231133.29990.jhb@freebsd.org>
In-Reply-To: <200610231133.29990.jhb@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200610240647.03765.davidxu@freebsd.org>
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/kern kern_exit.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Oct 2006 22:47:06 -0000

On Monday 23 October 2006 23:33, John Baldwin wrote:
> On Saturday 21 October 2006 19:59, David Xu wrote:
> > davidxu     2006-10-21 23:59:15 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/kern             kern_exit.c
> >   Log:
> >   Since revision 1.333 of kern_sig.c no longer uses P_WEXIT, the change
> >   opened a race window which can cause memory leak in signal queue.
> >   Here we free memory for signal queue when process state is set to
> >   PRS_ZOMBIE.
>
> Is there any reason to not just harvest it in wait() instead?

I prefer to free it earlier rather than delaying it if I can.