From owner-svn-src-all@FreeBSD.ORG  Fri Aug 13 09:12:54 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 15E291065675;
	Fri, 13 Aug 2010 09:12:54 +0000 (UTC) (envelope-from des@des.no)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
	by mx1.freebsd.org (Postfix) with ESMTP id C81278FC19;
	Fri, 13 Aug 2010 09:12:53 +0000 (UTC)
Received: from ds4.des.no (des.no [84.49.246.2])
	by smtp.des.no (Postfix) with ESMTP id D6FD91FFC33;
	Fri, 13 Aug 2010 09:12:52 +0000 (UTC)
Received: by ds4.des.no (Postfix, from userid 1001)
	id 96A1584528; Fri, 13 Aug 2010 11:12:52 +0200 (CEST)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Takanori Watanabe <takawata@FreeBSD.org>
References: <201008130045.o7D0jUW6043601@svn.freebsd.org>
Date: Fri, 13 Aug 2010 11:12:52 +0200
In-Reply-To: <201008130045.o7D0jUW6043601@svn.freebsd.org> (Takanori
	Watanabe's message of "Fri, 13 Aug 2010 00:45:30 +0000 (UTC)")
Message-ID: <86y6caswob.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r211252 - head/usr.sbin/acpi/acpidump
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Aug 2010 09:12:54 -0000

Takanori Watanabe <takawata@FreeBSD.org> writes:
> @@ -647,7 +646,7 @@ acpi_handle_tcpa(ACPI_TABLE_HEADER *sdp)
>  		printf(END_COMMENT);
>  		return;
>  	}
> -	printf("\tClass %d Base Address 0x%jx Length %" PRIu64 "\n\n",
> +	printf("\tClass %u Base Address 0x%jx Length %ju\n\n",
>  	    tcpa->platform_class, paddr, len);
>=20=20
>  	if (len =3D=3D 0) {

This is still wrong, just a different kind of wrong.  Just because the
compiler doesn't complain doesn't mean it's right.  Did you even read
what John and I wrote?

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no