From owner-freebsd-emulation@FreeBSD.ORG Wed Apr 13 15:43:34 2005 Return-Path: Delivered-To: freebsd-emulation@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 81BAC16A4CE for ; Wed, 13 Apr 2005 15:43:34 +0000 (GMT) Received: from mailout04.sul.t-online.com (mailout04.sul.t-online.com [194.25.134.18]) by mx1.FreeBSD.org (Postfix) with ESMTP id DE9AD43D49 for ; Wed, 13 Apr 2005 15:43:33 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from fwd18.aul.t-online.de by mailout04.sul.t-online.com with smtp id 1DLk1c-00075d-01; Wed, 13 Apr 2005 17:43:32 +0200 Received: from Andro-Beta.Leidinger.net (ZwKBZaZdYevnznB+3sHJcpWphZ3795pKBeN1MCIkktjQmFzKHgqU8g@[84.128.203.188]) by fwd18.sul.t-online.de with esmtp id 1DLk1S-0o8Oqe0; Wed, 13 Apr 2005 17:43:22 +0200 Received: from localhost (localhost [127.0.0.1])j3DFhG6h032167; Wed, 13 Apr 2005 17:43:16 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from 141.113.101.32 ([141.113.101.32]) by netchild.homeip.net (Horde MIME library) with HTTP for ; Wed, 13 Apr 2005 17:43:16 +0200 Message-ID: <20050413174316.9sygl52600ksgo88@netchild.homeip.net> X-Priority: 3 (Normal) Date: Wed, 13 Apr 2005 17:43:16 +0200 From: Alexander Leidinger To: Mark Linimon References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Internet Messaging Program (IMP) H3 (4.0.2) / FreeBSD-4.11 X-ID: ZwKBZaZdYevnznB+3sHJcpWphZ3795pKBeN1MCIkktjQmFzKHgqU8g@t-dialin.net X-TOI-MSGID: 16f84830-0e75-49d7-a381-ef2c0e508299 cc: freebsd-emulation@FreeBSD.org Subject: Re: RFC: cleanup of linux ports X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2005 15:43:34 -0000 Mark Linimon wrote: > It got changed not to be a pure trigger variable in 1.505, when the Yes, it's my mega-patch. I refered to it in my answer. > acceptable value '7' was added. Now we have the worst of both worlds. > If it can have multiple values then we have to test for illegal values > and reject them via IGNORE. Implicit in this is going and fixing the > two current cases where the value is not 'yes'. Otherwise IMHO this is > completely fragile. Again, consider what happens when someone sets > 'USE_LINUX=rh-7' which they might reasonably expect to do since they > can set it to 'rh-9'. It should fail, not silently give them RH 8. "rh-7" isn't allowed as per the documentation of USE_LINUX. > As well, I see this fragility as an opportunity to shoot ourselves in > the foot when changing default versions in the future. I see your point, but I think porters should be clever enough to know that they have to read the documentation. And the documentation explicitely says that the value has to match emulators/linux_base-. Since you're insisting on this functionality I will implement your suggestion (I assume you don't mind if I use "Requested by: portmgr (linimon)" in the commit)... maybe tomorrow. Because this change will need a fix to some ports too, I will add my complete patchset to the PR with the bsd.port.mk changes for extended testing on the cluster. Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 microReid /mi:'kroh-reed/ n. See microLenat.