From owner-cvs-all@FreeBSD.ORG  Wed Mar 17 02:50:53 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id C7F5616A505; Wed, 17 Mar 2004 02:50:51 -0800 (PST)
Received: from vexpert.dbai.tuwien.ac.at (vexpert.dbai.tuwien.ac.at
	[128.131.111.2])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 748AA43D2D; Wed, 17 Mar 2004 02:50:51 -0800 (PST)
	(envelope-from gerald@pfeifer.com)
Received: from [128.131.111.60] (acrux [128.131.111.60])
	by vexpert.dbai.tuwien.ac.at (Postfix) with ESMTP
	id 4E55513795; Wed, 17 Mar 2004 11:50:50 +0100 (CET)
Date: Wed, 17 Mar 2004 11:50:52 +0100 (CET)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: "David E. O'Brien" <obrien@FreeBSD.org>
In-Reply-To: <Pine.BSF.4.58.0403171036060.94079@acrux.dbai.tuwien.ac.at>
Message-ID: <Pine.BSF.4.58.0403171135480.94079@acrux.dbai.tuwien.ac.at>
References: <200403170818.i2H8IFYU008824@repoman.freebsd.org>
 <Pine.BSF.4.58.0403171036060.94079@acrux.dbai.tuwien.ac.at>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-ports@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/lang/gcc34 Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Mar 2004 10:50:54 -0000

On Wed, 17 Mar 2004, Gerald Pfeifer wrote:
> I did something similar to the gcc33 port over the weekend, but during
> my tests (on i386, for example) I still had to hardcode CONFIGURE_TARGET,
> though gcc34 builds just fine with your more minimal approach.
>
> Do you have any idea why that might be?

I'm afraid I know.  Your commit apparently broke the port an all platforms
but amd64. :-(

Have you tested this following the instructions at
 http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-testing.html
?  For invasive changes like this, I'd like to ask you to always test at
least i386 when committing changes to ports that I maintain.

Gerald