From owner-cvs-src@FreeBSD.ORG Mon Nov 21 18:17:35 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B112816A4CB; Mon, 21 Nov 2005 18:17:35 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.FreeBSD.org (Postfix) with ESMTP id DACD743D46; Mon, 21 Nov 2005 18:17:34 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.5b3) with ESMTP id 2371907 for multiple; Mon, 21 Nov 2005 13:17:10 -0500 Received: from localhost (john@localhost [127.0.0.1]) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id jALIGkcn070379; Mon, 21 Nov 2005 13:16:56 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: "Damien Bergamini" Date: Mon, 21 Nov 2005 13:16:54 -0500 User-Agent: KMail/1.8.2 References: <20051119165547.0A4BD16A43D@hub.freebsd.org> <4381FEDF.7080607@root.org> <00ff01c5eec3$3b0e6640$0300a8c0@COMETE> In-Reply-To: <00ff01c5eec3$3b0e6640$0300a8c0@COMETE> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200511211316.56666.jhb@freebsd.org> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=4.2 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx X-Server: High Performance Mail Server - http://surgemail.com r=1653887525 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Nate Lawson Subject: Re: cvs commit: src/sys/modules/iwi Makefile src/sys/dev/iwi if_iwi.c if_iwireg.h if_iwivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Nov 2005 18:17:35 -0000 On Monday 21 November 2005 12:44 pm, Damien Bergamini wrote: > I don't like the idea of keeping the firmware in kernel memory. > It's a rather big file (~200KB). > And there is one for each operating mode (BSS, IBSS, monitor). > > The second reason why I don't like KLDs is because they require > user intervention and users must know which KLD to load for the > mode they want to operate in. And if you put all firmwares in > the same KLD, you end up with a big fat 1MB file. > > I won't go back to anything based on iwicontrol. People simply > don't know how to use it. Trust me. There is not a single day > where I don't get email from people complaining about it. Whatever logic you are doing in the kernel now to figure out which firmware to use you can just as easily do in the kerenl and trigger it by sending a devd event. You could have the userland side do an ioctl to get the type of firmware the driver wants for example. There is _ZERO_ reason that you have to do this in the kernel. You can move this logic out to userland and be much more robust in the process. As it is, trying to do VOP_READ() in the resume path is going to greatly diminish the robustness of suspend/resume. Moving this to userland is not a hard problem. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org