From owner-svn-src-head@freebsd.org  Sat Aug  1 21:02:08 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 22A9E9B1B5F;
 Sat,  1 Aug 2015 21:02:08 +0000 (UTC)
 (envelope-from guy.helmer@gmail.com)
Received: from mail-io0-x233.google.com (mail-io0-x233.google.com
 [IPv6:2607:f8b0:4001:c06::233])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id E0FBFA01;
 Sat,  1 Aug 2015 21:02:07 +0000 (UTC)
 (envelope-from guy.helmer@gmail.com)
Received: by ioeg141 with SMTP id g141so114912175ioe.3;
 Sat, 01 Aug 2015 14:02:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=content-type:mime-version:subject:from:in-reply-to:date:cc
 :content-transfer-encoding:message-id:references:to;
 bh=xW0sl/cK85ek9mPHmPXRBFJrdIOs4dbWWJgBuGqFdxE=;
 b=nRAQhIF+aglT/tOcYlQuwJUeu6cSf/lSNh7ZrdcdjuGDH0bfK2vjNSd0qGq6e3uUdl
 41oVnavcyTI5ve3/I5KqBHSMwtj1rQTVZMcfdg2kCf3vcZhahhZRwG2WxBqhXGwcYQN4
 JkXBM552rLoQAzhMkTD/EqnFxt/zz8AWap0M0X/bjRDMRsDjV0yREEQkAJuDoIYXKtR4
 RUYGyI5TTRBFfnVTQOZsZYSObvqnKhW13f/AG3d+M7gje8mYns0CJ+dG/0p2Jp3nGumy
 0U5GuQ/8IzjnL4h5J9MLh4x0YJe1R9RymsabmJSSchCirW0NyeAKng4WQGc11DbmyZS6
 F7PQ==
X-Received: by 10.107.10.167 with SMTP id 39mr15035297iok.0.1438462927350;
 Sat, 01 Aug 2015 14:02:07 -0700 (PDT)
Received: from [192.168.1.107] (173-29-96-237.client.mchsi.com.
 [173.29.96.237])
 by smtp.gmail.com with ESMTPSA id lr1sm2024978igb.10.2015.08.01.14.02.04
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Sat, 01 Aug 2015 14:02:05 -0700 (PDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\))
Subject: Re: svn commit: r286142 - head/sys/net
From: Guy Helmer <guy.helmer@gmail.com>
In-Reply-To: <CABh_MKn5vfXB4Hv3mfAVgy7g98_U+cQ=XKyVTLdVJO3pp0-05Q@mail.gmail.com>
Date: Sat, 1 Aug 2015 16:02:03 -0500
Cc: Luiz Otavio O Souza <loos@freebsd.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Content-Transfer-Encoding: 7bit
Message-Id: <EB54E04B-2312-495E-8D36-DD283582E256@gmail.com>
References: <201507312143.t6VLhSBm046797@repo.freebsd.org>
 <CABh_MKn5vfXB4Hv3mfAVgy7g98_U+cQ=XKyVTLdVJO3pp0-05Q@mail.gmail.com>
To: Ed Schouten <ed@nuxi.nl>
X-Mailer: Apple Mail (2.2102)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 01 Aug 2015 21:02:08 -0000


> On Aug 1, 2015, at 4:50 AM, Ed Schouten <ed@nuxi.nl> wrote:
> 
> Hi Luiz,
> 
> 2015-07-31 23:43 GMT+02:00 Luiz Otavio O Souza <loos@freebsd.org>:
>> -               while (d->bd_hbuf_in_use)
>> -                       mtx_sleep(&d->bd_hbuf_in_use, &d->bd_lock,
>> -                           PRINET, "bd_hbuf", 0);
> 
> Would it make sense to replace them by an assertion, instead of
> omitting them entirely?
> 
> KASSERT(!d->bd_hbuf_in_use, ("..."));

I would appreciate the confidence that would provide.

Guy