Date: Fri, 14 Jan 2005 10:33:35 -0800 From: Kris Kennaway <kris@obsecurity.org> To: freebsd-amd64@FreeBSD.ORG Cc: Kris Kennaway <kris@obsecurity.org> Subject: Re: cvs commit: src/lib/msun/alpha fenv.h src/lib/msun/amd64 fenv.h src/lib/msun/arm fenv.h src/lib/msun/i387 fenv.h src/lib/msun/ia64 fenv.h src/lib/msun/powerpc fenv.h src/lib/msun/sparc64 fenv.h Message-ID: <20050114183335.GA22659@xor.obsecurity.org> In-Reply-To: <20050114180939.GB12260@dragon.nuxi.com> References: <200501140709.j0E79NTA046894@repoman.freebsd.org> <20050114131536.GA41709@xor.obsecurity.org> <20050114132433.GA97735@VARK.MIT.EDU> <20050114132829.GA42958@xor.obsecurity.org> <20050114180939.GB12260@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--vtzGhvizbBRQ85DL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 14, 2005 at 10:09:39AM -0800, David O'Brien wrote: > On Fri, Jan 14, 2005 at 05:28:29AM -0800, Kris Kennaway wrote: > > On Fri, Jan 14, 2005 at 08:24:33AM -0500, David Schultz wrote: > > > On Fri, Jan 14, 2005, Kris Kennaway wrote: > > > > On Fri, Jan 14, 2005 at 07:09:23AM +0000, David Schultz wrote: > > > > > das 2005-01-14 07:09:23 UTC > ... > > > > > Log: > > > > > Mark all inline asms that read the floating-point control or st= atus > > > > > registers as volatile. Instructions that *wrote* to FP state w= ere > > > > > already marked volatile, but apparently gcc has license to move > > > > > non-volatile asms past volatile asms. This broke amd64's feupd= ateenv > > > > > at -O2 due to a WAR conflict between fnstsw and fldenv there. > > > >=20 > > > > Do you think this is likely to the cause of the build failures > > > > reported with a number of ports when world is compiled with -O2 > > > > (i.e. does the feupdateenv failure cascade to other commonly-used > > > > parts of the code)? > > >=20 > > > No, this would lead to a runtime failure, and I would be surprised > > > if very many ports use fenv.h anyway. > >=20 > > OK :-( > >=20 > > Someone needs to revert amd64 back to using -O in the meantime, then. >=20 > I can't tell if you're talking about a need to move back to -O is for > /usr/ports or /usr/src? src. This was discussed on current@ in December; some amd64 ports do not build when world is compiled with -O2 (even if the port itself is built with -O), but build when world is recompiled with -O. There was some analysis of the problem cause in the mailing list thread (which you were CC'ed on), but no conclusion. > If for /usr/ports, we should just change ports/Mk/bsd.port.mk to > s/-O2/-O/ on AMD64? If we move back to -O in /usr/src we'll never > get all the issues found and ironed out. The issues have been reported, so someone either needs to fix them or apply the workaround of reverting src to -O until the former can take place. Kris --vtzGhvizbBRQ85DL Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFB6BB+Wry0BWjoQKURAsdzAJ9kLkQ/y9GfBNLUrkNTwLxDUfE/+gCgxL5S 7fkH1m0BFjzw5rXFbEiUQXA= =p12H -----END PGP SIGNATURE----- --vtzGhvizbBRQ85DL--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050114183335.GA22659>