From owner-freebsd-ports@FreeBSD.ORG Mon Oct 1 21:34:07 2007 Return-Path: Delivered-To: ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BC0BD16A417 for ; Mon, 1 Oct 2007 21:34:07 +0000 (UTC) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id 7BBE413C459 for ; Mon, 1 Oct 2007 21:34:07 +0000 (UTC) (envelope-from sam@errno.com) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id l91L2YBT038807 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 1 Oct 2007 14:02:35 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <4701606A.60908@errno.com> Date: Mon, 01 Oct 2007 14:02:34 -0700 From: Sam Leffler User-Agent: Thunderbird 2.0.0.6 (X11/20070814) MIME-Version: 1.0 To: Andrew Thompson References: <20071001194035.GA1462@roadrunner.spoerlein.net> <20071001205635.GA34222@heff.fud.org.nz> In-Reply-To: <20071001205635.GA34222@heff.fud.org.nz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC-dcc-servers-Metrics: om; whitelist Cc: ports@FreeBSD.org, Sepherosa Ziehau , Tai-hwa Liang , Ulrich Spoerlein Subject: Re: struct wi_req: how to deal with removal, affects multiple ports X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 21:34:07 -0000 Andrew Thompson wrote: > On Mon, Oct 01, 2007 at 09:40:35PM +0200, Ulrich Spoerlein wrote: > >> Hi, >> >> on July 11th you removed the definition for struct wi_req on -CURRENT >> from sys/dev/wi/if_wavelan_ieee.h with the following commit message >> >> revision 1.21 >> date: 2007/07/11 21:25:48; author: thompsa; state: Exp; lines: +2 -0 >> Now that wicontrol has been removed from the base system the corresponding >> ioctls can be removed. These have been #ifdef'd out and left as a reference in >> case any of the RIDs need to be turned into sysctls at a later date. >> >> Reviewed by: sam, avatar >> Approved by: re (kensmith) >> >> I don't know why, but recently at least the ports xwlans and wmwifi fail >> to build because of the missing definition, I guess. bsd-airtools has >> recently been flagged as broken, too. Presumably due to the same reason. >> > > Up until that commit wi(4) was the only driver to support the > SIOCGWAVELAN calls, now it has been totally removed in favour of the > net80211 systems. > > >> How should these ports deal with this? Both are calling SIOCGWAVELAN >> with wi_type set to WI_RID_COMMS_QUALITY. >> > > I guess these ports should be updated to use the IEEE80211_IOC_SCAN_REQ > and IEEE80211_IOC_SCAN_RESULTS ioctls. These are driver independent and > supported by all the wireless drivers, src/sbin/ifconfig/ifieee80211.c > is a good reference. > > I see that wmwifi-bsd.patch from wmwifi could be updated reasonably > easy, I can help if you like. > This issue came to me previously and I said basically the same thing--the old api's were deprecated long ago (w/ the promise to pull the plug in 7.0). For example, I offered an updated dstumbler that read radiotap with libpcap for many years but noone updated the port. Anything wireless should use the current ioctls and if there are any issues I will help. As Andrew mentioned ifconfig is the best reference for the moment (though I have changes to make the code less of a steaming pile of hacks). The best solution would be for someone to take the ifconfig code and write a library. Sam