From owner-freebsd-stable@freebsd.org Fri Mar 1 00:54:03 2019 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1DAE51520559 for ; Fri, 1 Mar 2019 00:54:03 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 559496B231 for ; Fri, 1 Mar 2019 00:54:02 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: by mailman.ysv.freebsd.org (Postfix) id 191761520558; Fri, 1 Mar 2019 00:54:02 +0000 (UTC) Delivered-To: stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 06C081520557 for ; Fri, 1 Mar 2019 00:54:02 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 66E556B22D; Fri, 1 Mar 2019 00:54:01 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x210rpnF058633; Thu, 28 Feb 2019 16:53:51 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x210ro2G058632; Thu, 28 Feb 2019 16:53:50 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201903010053.x210ro2G058632@pdx.rh.CN85.dnsmgr.net> Subject: Re: FreeBSD 12.0 RELEASE i386 can not build a kernel? In-Reply-To: To: Warner Losh Date: Thu, 28 Feb 2019 16:53:50 -0800 (PST) CC: "Rodney W. Grimes" , Ed Maste , Konstantin Belousov , stable@freebsd.org, Dimitry Andric Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 66E556B22D X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.989,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Mar 2019 00:54:03 -0000 [ Charset UTF-8 unsupported, converting... ] > On Thu, Feb 28, 2019 at 10:00 AM Rodney W. Grimes < > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > [ Charset UTF-8 unsupported, converting... ] > > > On Thu, 28 Feb 2019 at 09:33, Rodney W. Grimes > > > wrote: > > > > > > > > LD?=ld.lld in the right place(s)? > > > > > > Perhaps, I seem to recall some issue with that, but not the specifics. > > > > sys.mk already does a LD?=ld so by the time we try > > to override it in the Makefile.i386 it is too late > > as already defined. > > > > *sigh* > > > > Yes, the problem is that ?= only works once. There's some gross things we > can do, but they aren't worthwhile, imho. > > eg > > .if defined(KERNEL_LD_OVERRIDE) > LD=${KERNEL_LD_OVERRIDE} > .else > LD=ld.lld > .endif > > or other variations on that. We could do it without the .else clause and > just add KERNEL_LD_OVERRIDE=ld.lld to GENERIC on i386 as a build-time > override. This would give people a way out, but would violate POLA a little > bit. Given the frequency of overriding LD=, it may be OK. People > sophisticated enough to do that surely are sophisticated enough to read > changes to the kernel config files. This wouldn't help everybody > (especially those with custom kernel configs), but short of adding it to > DEFAULTS, it's likely pushing the edge of how disruptive one can be in a > stable branch. > > So there's a number of variations on this theme. I'm not convinced they are > worthwhile for this issue because none are side-effect free, but it's > certainly a solution space others can noodle through to see if they can > find the "just so" mix of POLA and bug fixing. I would be happy with expanding the error that is emitted by pre.mk to add the text "You can fix this with LD=ld.lld make ..." and an entry in UPDATING that specifically says for 12.0 on i386 you need... > Warner -- Rod Grimes rgrimes@freebsd.org