Date: Wed, 22 Sep 2010 12:27:14 +0400 From: Anonymous <swell.k@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/150854: [patch] ftp/curl: respect -g[0-3] and -O[0-4] in CFLAGS Message-ID: <86hbhimbdp.fsf@gmail.com> Resent-Message-ID: <201009220840.o8M8e1c5023536@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 150854
>Category: ports
>Synopsis: [patch] ftp/curl: respect -g[0-3] and -O[0-4] in CFLAGS
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Sep 22 08:40:01 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Anonymous
>Release: FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
>Description:
Don't override DEBUG_FLAGS either added via WITH_DEBUG or manually,
i.e. remove -g0 for WITHOUT_CURL_DEBUG and -g for WITH_CURL_DEBUG.
And erase -O2 from flags_opt_yes in case CFLAGS doesn't have -O2.
>How-To-Repeat:
$ export WITH_DEBUG= DEBUG_FLAGS=-g3
$ make -V CFLAGS
-pipe -g3
$ make
...
libtool: compile: cc -DHAVE_CONFIG_H -I../include/curl -I../include -I../include -I../lib -I../lib -I/usr/local/include -I/usr/include/openssl -I/usr/local/include -pipe -g0 -O2 -Wno-system-headers -Werror -MT http.lo -MD -MP -MF .deps/http.Tpo -c http.c -fPIC -DPIC -o http.o >/dev/null 2>&1
Neither -g0 nor -O2 is present in CFLAGS.
>Fix:
--- a.diff begins here ---
Index: ftp/curl/Makefile
===================================================================
RCS file: /a/.cvsup/ports/ftp/curl/Makefile,v
retrieving revision 1.110
diff -u -p -r1.110 Makefile
--- ftp/curl/Makefile 12 Sep 2010 21:05:47 -0000 1.110
+++ ftp/curl/Makefile 22 Sep 2010 05:35:52 -0000
@@ -221,6 +221,10 @@ DOCS= BINDINGS BUGS CONTRIBUTE DISTRO-D
curl-config.html curl-config.pdf curl.html curl.pdf \
index.html
+post-patch: .SILENT
+ ${REINPLACE_CMD} -Ee 's/(flags_(dbg|opt)_[^=]*)=".*"/\1=""/' \
+ ${WRKSRC}/configure
+
post-install:
.if !defined(NOPORTDOCS)
@${MKDIR} ${DOCSDIR}
--- a.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86hbhimbdp.fsf>