From nobody Wed May 7 21:37:19 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zt7rw477Lz5vKPx; Wed, 07 May 2025 21:37:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zt7rv2sQ5z3mPd; Wed, 07 May 2025 21:37:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746653839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5FW+hjALNT2H+iUAFrQPo1rFSrY3uM1F+p4DwMTYBqA=; b=gIHzar+vUonXIqSJxyR30jLOBtFqcRUvX25hknPiJhfzZvVAG1cgqQmvrFvbGx4/0jbY1j hJTM9iYn6eShE243BiOcbn0LvC2TCUnmI0WAFWsccTD91mFVt9t12UqS30p/xkFDLHCFyA +SzAr5LCZ2zkEOaKt6CnBUxnQJDcTvXxWahzmVkqpGwacIu4ZVW9QIj5nOP/1OlFTo9Poi fc3ZsUJ9PQM7oX2hkY5CJGjDu4IWM4bJh8iUJSu9bxfTGxsmLOKRT/v9SirhJ5JxAOeEK+ ZhBkssqM63fZefqseDuPNtBTDOvOokdEZzHm79oznziqF1QRHQCqHxlCFBpkAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746653839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5FW+hjALNT2H+iUAFrQPo1rFSrY3uM1F+p4DwMTYBqA=; b=nNbR4TaV10f7S6NyyQJxZi1so2NYCbJjYH10SePIJILUvOinDlSk9Mr8xGjwq9gUVufg4b Ah9M6eVxsHw5PNZvdq33oXbHt19IhyNSpXhy3iPGgeWt6eE0GAbqiS3idyI43SkgWF376O PXGe5CMcQ2Fxn8RtJvJZYNlch5crmjUxnWB55MKQasnIr/aof76AxDBCQlz74WgoVW9R9L NZ/i8Ql+J6YvpxKNzDEvWAIw4CXSApJ6k+ZgzQtfHaRicvnDQYB0RrgmBMSRhm0Ae44Ecc N4lxkPWcI6CF13gQQ8sDxTnRsPuSSVGDS4hEpod7cQ50n1Ih3TnV1/6iUQyTyQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746653839; a=rsa-sha256; cv=none; b=rUzOq1mcKX8T8XT7zkFFtdUYYlrfC8mvD5H4fXN3Cqmi5kF0ui0euFtyj0nNa/3LNhIMXg krkfUUc2F5is48XLWNPtS5Lal/ls4EWzqbrjpUlkKhqv1vttDHq9EVMuGr8rqcfvX09jnS iIHehk4iK8GW4v/aPBKIB4cDDBSlDQ1OPEo0jBCQ86yIK74Ka7PypU7LkIOX7rMOWJe78H /oNBaRhtdhbPjXX9G3V5JVCMlFAjeSvko2km242ZY/d8sne99vcrkXy58vMPKqJie/8d2L YXdbbzVmNCT5C6GYyI/pv6iBgfArhx9Q39PrYlEE+7xnOyc7NI79W/EdURI85w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Zt7rv1rVNzmcs; Wed, 07 May 2025 21:37:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 547LbJQT092359; Wed, 7 May 2025 21:37:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 547LbJSM092356; Wed, 7 May 2025 21:37:19 GMT (envelope-from git) Date: Wed, 7 May 2025 21:37:19 GMT Message-Id: <202505072137.547LbJSM092356@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 6f8fbb2adfde - main - usb/quirks: Remove overly broad quirks List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6f8fbb2adfde9eeb2b13e693e8be19a08e9d0ad4 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=6f8fbb2adfde9eeb2b13e693e8be19a08e9d0ad4 commit 6f8fbb2adfde9eeb2b13e693e8be19a08e9d0ad4 Author: Warner Losh AuthorDate: 2025-05-07 16:08:51 +0000 Commit: Warner Losh CommitDate: 2025-05-07 21:36:55 +0000 usb/quirks: Remove overly broad quirks Now that we have a safe way to detect the vast majority of problems with SYNCHRONIEZ CACHE, and since I have devices from many of these vendors that work just fine (one of which will hang if you send it a SYNCHROMIZE CACHE), I think these should all be reverted. The details of when they were added are sketchy, the age of the devices in question means these vendors have many generations of products after and the general over-quirking of SYNCHRONIZE CACHE all point to just removing them and adding back specific quirks should any need arise after trying other means to debug. The APPLE quirk was added because the autoquirk code would hang an ipod with RockBox with a reset loop in the firmware. Since it was quirked, it disabled the autoprobe and started working. Now that we've disabled the autoprobe, we can remove it for sure. Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D49478 --- sys/dev/usb/quirk/usb_quirk.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/sys/dev/usb/quirk/usb_quirk.c b/sys/dev/usb/quirk/usb_quirk.c index 653395bbdac9..64396918a3d7 100644 --- a/sys/dev/usb/quirk/usb_quirk.c +++ b/sys/dev/usb/quirk/usb_quirk.c @@ -565,16 +565,6 @@ static struct usb_quirk_entry usb_quirks[USB_DEV_QUIRKS_MAX] = { USB_QUIRK(PLOYTEC, SPL_CRIMSON_1, UQ_CFG_INDEX_1), USB_QUIRK(ROLAND, UA25EX_AD, UQ_AU_VENDOR_CLASS), - /* - * Quirks for manufacturers which USB devices does not respond - * after issuing non-supported commands: - */ - USB_QUIRK_VO(ALCOR, UQ_MSC_NO_SYNC_CACHE, UQ_MSC_NO_TEST_UNIT_READY), - USB_QUIRK_VO(APPLE, UQ_MSC_NO_SYNC_CACHE), - USB_QUIRK_VO(FEIYA, UQ_MSC_NO_SYNC_CACHE), - USB_QUIRK_VO(REALTEK, UQ_MSC_NO_SYNC_CACHE), - USB_QUIRK_VO(INITIO, UQ_MSC_NO_SYNC_CACHE), - /* DYMO LabelManager Pnp */ USB_QUIRK(DYMO, LABELMANAGERPNP, UQ_MSC_DYMO_EJECT),