From owner-freebsd-hackers@freebsd.org Thu Mar 29 00:13:48 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 34627F57EAB for ; Thu, 29 Mar 2018 00:13:48 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.pphosted.com", Issuer "thawte SHA256 SSL CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 86B2B6B31D; Thu, 29 Mar 2018 00:13:47 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from pps.filterd (m0108161.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w2T08tLu011245; Wed, 28 Mar 2018 17:13:46 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=to : cc : subject : in-reply-to : references : from : mime-version : content-type : content-id : date : message-id; s=PPS1017; bh=7KUiS1xIMWy80v5ZDYy+qQ2b2h97Vg9EYxL9btbBD5Y=; b=PNodiO4ZMY19QMncM4/Alq3VGDbWpWgqJSsbWDMcSb/JW85iVRNd4zuytuUe9hYgv+Ag rXfFtLxnfGMUY/WnM+7CqTvnM8u0W8KRbT94Ei0TxdKXJkh7Rzk4C+itdVntBhwSXEJU n/pTLyQwIyt9RGFOxvN0gP4JLHKmCi8xKqX/hO+b45vB1cd+55TJ0kaygrnOuDNxJrPy RwFVvQby9saqH/6fGLvgobl9VFojTDhgM37bMoC84ap+mCfaaFxDyVuBfeOCubPSUdVB SRxh8jcg/RhCLA2g0FF0VijyyT0JMnKvEkqse2PPQw88ENXVfIsIQo6DE66N9uCXowuh Jw== Received: from nam03-by2-obe.outbound.protection.outlook.com (mail-by2nam03lp0052.outbound.protection.outlook.com [216.32.180.52]) by mx0b-00273201.pphosted.com with ESMTP id 2h0gjagh2u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Mar 2018 17:13:46 -0700 Received: from SN1PR05CA0003.namprd05.prod.outlook.com (2a01:111:e400:5197::13) by CY4PR05MB3063.namprd05.prod.outlook.com (2603:10b6:903:f8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.631.5; Thu, 29 Mar 2018 00:13:44 +0000 Received: from DM3NAM05FT045.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::200) by SN1PR05CA0003.outlook.office365.com (2a01:111:e400:5197::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.631.5 via Frontend Transport; Thu, 29 Mar 2018 00:13:44 +0000 Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.12 as permitted sender) Received: from p-emfe01a-sac.jnpr.net (66.129.239.12) by DM3NAM05FT045.mail.protection.outlook.com (10.152.98.159) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.631.2 via Frontend Transport; Thu, 29 Mar 2018 00:13:44 +0000 Received: from p-mailhub01.juniper.net (10.47.226.20) by p-emfe01a-sac.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.123.3; Wed, 28 Mar 2018 17:13:43 -0700 Received: from kaos.jnpr.net (kaos.jnpr.net [172.21.30.60]) by p-mailhub01.juniper.net (8.14.4/8.11.3) with ESMTP id w2T0Dc9B026765; Wed, 28 Mar 2018 17:13:43 -0700 (envelope-from sjg@juniper.net) Received: from kaos.jnpr.net (localhost [127.0.0.1]) by kaos.jnpr.net (Postfix) with ESMTP id 5681351335; Wed, 28 Mar 2018 17:13:36 -0700 (PDT) To: Pietro Cerutti CC: , Subject: Re: bmake: variable modifiers in SysV include In-Reply-To: <20180328115825.ydfnbly6hpsvbo3h@ptrcrt.ch> References: <20180328115825.ydfnbly6hpsvbo3h@ptrcrt.ch> Comments: In-reply-to: Pietro Cerutti message dated "Wed, 28 Mar 2018 11:58:25 -0000." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 25.3.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <990.1522282416.1@kaos.jnpr.net> Date: Wed, 28 Mar 2018 17:13:36 -0700 Message-ID: <4361.1522282416@kaos.jnpr.net> X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:66.129.239.12; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(376002)(396003)(39860400002)(346002)(39380400002)(2980300002)(189003)(199004)(76506005)(7126003)(6916009)(229853002)(5660300001)(105596002)(69596002)(77096007)(26005)(117636001)(186003)(53936002)(107886003)(47776003)(486005)(97876018)(305945005)(46406003)(54906003)(2810700001)(486005)(476003)(126002)(2906002)(6246003)(76176011)(7696005)(11346002)(446003)(356003)(8676002)(6266002)(9686003)(106466001)(50466002)(450100002)(68736007)(86362001)(336012)(23726003)(97756001)(55016002)(16586007)(8936002)(81156014)(81166006)(50226002)(97736004)(53416004)(4326008)(316002)(478600001)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR05MB3063; H:p-emfe01a-sac.jnpr.net; FPR:; SPF:SoftFail; LANG:en; PTR:InfoDomainNonexistent; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: 1; DM3NAM05FT045; 1:lj+j6MfpXTFZ1YdN1M2up+u1keIuu+vqf7GJ5QTG+JrFqErZX1kUgDRD5efIMDMrBhO2onnWUesPsdBHot4X/PcfedjnpKemkQIQdYIVDbb63oWnHkWWvQWrOQXdCwoO X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0d4a78a2-c593-4fd1-9a53-08d59509ef5b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060); SRVR:CY4PR05MB3063; X-Microsoft-Exchange-Diagnostics: 1; CY4PR05MB3063; 3:f0zCKkw76iAu7ndyoUyOFFz0K6MHjPeRLrpZJDLXRdtlH8X1fr8T3hKE32G5cHH00J5+fQBz9tMV5w8MoNWCWlnhn7xR9V3Qy6b5Dy23JxKMFTWbolxO5kcTrvE17Bog1PWgsWBB/sdQPyISdKgNxjUOk24rab8e7KZNMn1OT6j62r7QPxX8uKCKNBZ7o9ivSzv+BTYycBPPcxdw3nTBAQ0vJEQ2laD/pwB5Kq5ni7zHNz2lsOciHbPtil6ewZBUpEtRrYdvxe8mjWYlH6jwU6c0BwUJtqsbzqWdyddTPrudzIyQp0QLfNwp40BiiDTx2z2s0RMimkHaTf9khC/CrYUvrkVpU49HcXnudQTbBp0=; 25:yWl5uVmDIm4KfPcOk/a3kbWnE2uDJKQKWW2Jt5iCb/xiAE7Ccd7/v/aJy5zaq7ATXZs5GIcdhMY9WTv/xlecEM824/AfXo1cTUo3kI6W2SmbmLhKnhVEtPdiu0ecDHl5uUyI1Xekth73YSUrYGy2WwEuUkaQrEH6v5ZAbmdWm54DIUFtckEfgYkXAp4m/6NwLuqf1fgtD8qHdW7az9iFUAJLOGPvd39NOEwChXbrLF9SM/cLssMfYbZmI3YWurFDauQopK0RJ0NFgK6TENZCodLmXHSwnwMUw15++DJqA/IH4vgNxMA5E0SoteY9bRzyiJpDgv2NiKGL0aiFsgYN2A== X-MS-TrafficTypeDiagnostic: CY4PR05MB3063: X-Microsoft-Exchange-Diagnostics: 1; CY4PR05MB3063; 31:mmiKUyKdRUK2x7kLTm6QryAjeYAnU11QS7u+yVxbaLXH/ky/nFSjImGIQHWGWPHNrPl1EmcsnWQx23hLyGGwaCFG+BvBHuG/WTDkUkp1VeArzUIAD9IzoFPf6VSb+px0IpFfZ7/QoA3uZYLTeXNaV8/cg2bK7if9yBBxgsjOn1XYt0CF8h+JvQTD8oZZFRPun1hFHxJJ3jl6sRS/On4NprfJj1kQNK0LY9PxiA9SzBE=; 20:ftxqy44jTBm0NaDr2UUnyEV4eyhCK7rGk/nY/Ybslu/dSQpU8B2U9TlfuU56+qGfxOxS/1GdCIcANYvrETfRpB99dndN6xAJxTbuw0be5uJkEjS9NGY2Ry0yMt/p2XPj09eJCX+U0rkCbyiw5UyO9kSnLTV0+VpaMCeVHpgxw/ae+yuWmtAjcq1TIcOfRBWVQDS5TLs2nQCkpdnU8MFIxRyEB5Ok9j9a04xmAgZXnbG8845MbfHwPJ58Y3SyVH1lRWXIt5jS9i6cFAImB/zudVAcVjPvt0DPJutuN8H0HlKQ66CHpmPkyxBdf/RCJNvEQcAj4GewI9yg2ZXvZPyjiMyexTbzgZyOnpvUh/TMMFEIRw++rZA67P4UfcJC5h0GZV/SPhszvFX6uxwp10WBn1Y86CQLvO3yS4Q6BRbeTugJ7gU+D9deKikpkOaluGsssc0Pxqa70x/8LajlRR+seh9lw8Hwru6Qa48pMuZziJQpvWPS4vmZ6WXVSGgwqy/b X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501327)(52105095)(93006095)(93003095)(3002001)(10201501046)(6055026)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:CY4PR05MB3063; BCL:0; PCL:0; RULEID:; SRVR:CY4PR05MB3063; X-Microsoft-Exchange-Diagnostics: 1; CY4PR05MB3063; 4:Vbzue2Dr9SfTgCWb+/Z/mToddJrVa4n3oFqUiq9rF5xPkh4Z4Utm2MQBM1KMxQcWTThNkM9+n1et7g43nMD9ogN6v1bG+3glEuenkqDLUHG54nucEczO2gGQlSuH3yP2spKcVY3+0Kgce9/A3lIYRVbSmBWDWskUPV0anQitvhgyF3REHD1of2SuzBU4x4xTIHFglAMTuXIn+7crWXvWA8SVb6jSgYQ/Ren63+3QoL4SGnEXg+EU1t6+Pheb8Y9esTs3jrkJTSSq8vBN9sSRBQ== X-Forefront-PRVS: 0626C21B10 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR05MB3063; 23:RaDaMQYJXoiYP0nsFDJ1L9HlRot6UbTc42w0vHhMW?= =?us-ascii?Q?j51gS3Sd6HcNQ2lcieyN4JuQWNcvyMPNeeMGyT9zjg6+EE/zje6AeCUI87Yw?= =?us-ascii?Q?AYVRALVAzuGXHqMYQeZOeG8CJsIunwBSXAngyzbm229316J2mTFA7GbLYcb3?= =?us-ascii?Q?mdNPhOujavQolirkFU0G442hHD7+/AN5pHTZWcCX3Vanzso5qIkh5xSMf32L?= =?us-ascii?Q?ehjgwVFlqArTbvtgDwk56RVB7c/gTrqIOoWIJQINjlCpkkaC6e70lEIsDBLy?= =?us-ascii?Q?qe9QDV6dpHGBm0qr0xfE2pxYOmtCe9c7jpH7lC792WSyoROH3IPMVbwenj4i?= =?us-ascii?Q?df+rtpft5/fzd3RmoHJFSqvSgprFniI4O9XGYiLrObxQ0eoqZBii+Hc0m7SY?= =?us-ascii?Q?amy3hkNAgMk4oWsnPWoR6ac45dvFPodyuwsk9uWTdZpWhoyD2hDbOFAMcalz?= =?us-ascii?Q?3+ZI1Z3PV5gidyWF8UGVrJq+8z+uSWzauMtivvKnCSFtrlgYbGzBXgETuJWC?= =?us-ascii?Q?QuNsD+d6JHn+3H5Q4TUv85cVJrhW/6QFSWEpayvu6ZRB4J9s7HbFyr0LIHOZ?= =?us-ascii?Q?Q6QnIrNCGfKCc2Lby0jtkO3scKU+zhD2SYlkKjL5FfVJ9TocT+VMSJTQMqiW?= =?us-ascii?Q?fdyx3c7BAlrIw1A4ZZlu8YTTLV52Qklp7iu/k/cBTg/GKyEeag0pzSxfUaeK?= =?us-ascii?Q?56ALACS4RwrW69DFuTULyvRwjSHzR7ZumwcvLs8V0T0wG+T+aMC/JJXfUidI?= =?us-ascii?Q?lJrj61P1pileaCpqyReOmPqXuIOOh3EprmK91t7xJPJdz6h00Cyvv8dgsNZT?= =?us-ascii?Q?tpAqCeSOIqF/sxBxlR8ncAlxCJjTRwKkLVEfYF+kqB2o5ZAURa0reWPaUHNH?= =?us-ascii?Q?1cD6BBc6h7KJrqcuxNq36pzUIGRJ/4l0s1AMZ0b1G110HSR917FDLRznlGjd?= =?us-ascii?Q?PZMUOtcpeUmIZ8Osm6e+VDevP2Kn348k+3szAYTVoNF1lNALI2U4FooQahYw?= =?us-ascii?Q?91Yc0nUsc1sdOOXg+aD1duGLNYRHfYTCjmN5DAuYcLIH1KLzWQTnzut5rAJg?= =?us-ascii?Q?aCC796GSXVmiITAr3hloiiXJaLgYJ5a5jzAUXhbhZhT9v6LsYGDciYgU3dTw?= =?us-ascii?Q?WvXGkM2ysJbKetd3oqcUUt7ayJxDb8dSiZ9xTJiUIy1oMpnlC3Csc1LVtzv/?= =?us-ascii?Q?H5qIjtmvK+XJZBIOIU+wm41f9tTAdJsx+6DRvvFo1P84l2QQJPIW4KBwsmtk?= =?us-ascii?Q?57ap6nnwc7kHmwOVRGdzi3y0PNL7IKOJH0cb+zRG2KgtGbAbVcR39trj/Wvs?= =?us-ascii?Q?SzknDThRmIZZc+/ZjdRIvC7D4GzoXpCEBuBVBz4D5lfG2aoOa6GwhfZAeun5?= =?us-ascii?Q?3RHFA=3D=3D?= X-Microsoft-Antispam-Message-Info: oOW66rAWAlcZoODo1DVTGER70dOuxMnIPHRNkugkHIE5mirCDHgHDrg0djcQW/tTY1WHQfs9BcALdpuqdaCW2XJ06g2R16NlZJhFxY6R3JWlum9ilSaZgIFzIkuztnhyouRVvcnhEu+WMwG1jOiZvjKsv2qXxdK2g0uDadK/T+uO+DIw7bHj4YATLmtQF7Cz X-Microsoft-Exchange-Diagnostics: 1; CY4PR05MB3063; 6:Wxq3ElmHDJJKoxS2UJwb3mdLcY+chfYLaYnbhg5KPYcw6acXusyv/imK/FF++NKI9SjdJIs1ddzSnyPD1FUIikvhDKyODXU0nGU+ikLwIhBSe+NIW//MypfDUCcd8P+fZQJiLP2bovSGDibvp5hIvhdBIyzpb5PCByW4hYDErj/eGpGasfNH5B7s6I9iJadH2t96V+HFK7xpMGEC35dKevAq3Evo7Aa+DwY0acHD1IPWP0bqvFZo9lbhqj4t0ikjQsz5KNOsPWiQmetyrDtG32tZJGETPdmfCWl5d0XFex8cEnOvf2rCTY8NrPxfnfZjiuYlDrCMxmUG1jSEuu3beUpS+MZ9lP1xfCzOoJ+jkPjL9IT/nw5lw8F+hTro5/elyBl3anG94QTjWLMtB7f/nqoDoTOncdfBrYWY02tPhgy9O2y8vqZGPX1RHkKatVrV6eNXObZu2TA5LnP3VT6NWw==; 5:6gXiIN0Wnk9MrcR58XtiQ8xaM6e2qbtg5Km8H/fUqqRTIlxGmjTtt/6m6JiLxaIQRteqFr82HVogZD4VgFRucVmMOEB570VSKd34eIo0maJdJDz5M8wbta0HAe9kfY/zuTfUFX4AHZ6tYyQUBqZ0y4o9l478kTzpY9ozuomjIVQ=; 24:A9i/Zhu8Rh7oglyWU+txR4znADGDM4keiDmj9tFMz4zaRTPK+80dlfdsSo3p7H22/hWLtC7/pvM4U5ebDk9jVDrrgp4PlcfW3VhCiTDlkCk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR05MB3063; 7:HHa3D51xIW6rVCR+oWvqaGSoYDNM/pX/E0xPY3xH4eMsoocskwNFCWUUJSGSQIVkivCDjWnLyeTRZpaej8vtmAjxrFhxUmkmu2ylCfCH0V84AG+FsgeSJxDH0NHt08vfMSUwSdhfwj/rG/M8vKdesjlR2wzLLCB3hf1cB0D79E3TEz2Isog4evkRycvpCBlXhNyuqoRlZusEadJtQc0O/nrqHIg7iPQzONORHOiexsiRwm0/i3cOTr9ZJPQ1T0nV X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2018 00:13:44.2826 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0d4a78a2-c593-4fd1-9a53-08d59509ef5b X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.12]; Helo=[p-emfe01a-sac.jnpr.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR05MB3063 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2018-03-28_08:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=647 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803290000 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 00:13:48 -0000 Pietro Cerutti wrote: > our make (contrib/bmake) does not currently support variable modifiers > in SysV-style "include" directives. See this simple example: > Apart from parentheses reshuffling, the patch just removes a check > that inhibits SysV inclusion if the line being parsed contains a colon > (:) character. > > This has been there since bmake has supported SysV includes [2]. > > Questions: > > 1. Any ideas why the check is there, and what problem it's preventing? > 2. Anybody with src bit would like to approve me committing the fix? Can you pls fwd your issue to tech-toolchain@netbsd.org (cc me) that way whoever it was who added the support for sysV style include can comment. Thanks --sjg