From owner-svn-ports-head@freebsd.org Wed Mar 22 05:20:17 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1CBB9D15300; Wed, 22 Mar 2017 05:20:17 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id C4BDCC81; Wed, 22 Mar 2017 05:20:16 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id qYgvcV1Z5UiwTqYgwc6Nn1; Tue, 21 Mar 2017 23:20:15 -0600 X-Authority-Analysis: v=2.2 cv=Qo0u5R6d c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=6Iz7jQTuP9IA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=xCuekCPEkCFZyQDUSGkA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id 76CFF327; Tue, 21 Mar 2017 22:20:13 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id v2M5KCnA030620; Tue, 21 Mar 2017 22:20:12 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201703220520.v2M5KCnA030620@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Gleb Smirnoff cc: Cy Schubert , Gerald Pfeifer , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r436576 - in head/emulators/wine-devel: . files In-Reply-To: Message from Gleb Smirnoff of "Tue, 21 Mar 2017 22:11:10 -0700." <20170322051110.GC23308@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 21 Mar 2017 22:20:12 -0700 X-CMAE-Envelope: MS4wfPdNLpUwVWQkqzX8YYN0W7suZiP4VaR8vEpiiWg5f8FnN6Mg+lN0SFXuOueW5WX8YHNrcmViYGLMCKV29POZXGMW2BRV/QSrXTQm0jFRwDHKhrjrCV+K Xq9hD+TFi3XRrKAW5+JsD6ZPUIMS19dCgssjAFAfuwCFwX2EvETafUl+vI+cgHNDO69u72Ij5suxbZQXMFlDBkmavl9kxrF7fPa7B/mKA6vCE0WUSkLorVbW 5V7FtJu+d+iCf/A5e9CjAP0ekWQ8OZm+06Sj+B55Djf/rfRZEP2+RlU8HmpHVKAIpIsSaJycC9T8bfKD0mkV+w+cWyHjV3y6FHdCsM3I7j0= X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 05:20:17 -0000 In message <20170322051110.GC23308@FreeBSD.org>, Gleb Smirnoff writes: > On Tue, Mar 21, 2017 at 10:09:35PM -0700, Cy Schubert wrote: > C> In message <20170322041508.GA23308@FreeBSD.org>, Gleb Smirnoff writes: > C> > On Tue, Mar 21, 2017 at 10:35:39PM +0100, Gerald Pfeifer wrote: > C> > G> > But without the bump I can't enforce rebuild for FreeBSD 12 users, > can I > C> > ? > C> > G> > C> > G> Well, it did not build for FreeBSD 12 users without your patch, or > C> > G> did I misunderstand? > C> > > C> > The version built earlier won't work properly on newer head, so we > C> > want users to rebuild. I thought bumping PORTREVISION is the right > C> > thing to do. > C> > C> Generally, if it's broken and the commit fixes the build, no PORTREVISION > C> bump is needed. > C> > C> If the ABI in base changes, then a PORTREVISION bump is also required. > > Thanks for explanation. The latter is the case (ABI changed), so bump > was useful. Examining the code I saw that. PORTREVISION forces a build. If for whatever reason we want to force a a rebuild of a package then we need to bump PORTREVISION. If there's any doubt it's better to force a rebuild than not. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.