From owner-svn-src-head@freebsd.org Thu Dec 24 22:05:35 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E341CA51599; Thu, 24 Dec 2015 22:05:35 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail108.syd.optusnet.com.au (mail108.syd.optusnet.com.au [211.29.132.59]) by mx1.freebsd.org (Postfix) with ESMTP id A4FB91813; Thu, 24 Dec 2015 22:05:35 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from c211-30-166-197.carlnfd1.nsw.optusnet.com.au (c211-30-166-197.carlnfd1.nsw.optusnet.com.au [211.30.166.197]) by mail108.syd.optusnet.com.au (Postfix) with ESMTPS id A419C1A5F78; Fri, 25 Dec 2015 08:45:53 +1100 (AEDT) Date: Fri, 25 Dec 2015 08:45:50 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Konstantin Belousov cc: Bruce Evans , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r292620 - head/sys/kern In-Reply-To: <20151224205730.GC3625@kib.kiev.ua> Message-ID: <20151225083416.K1523@besplex.bde.org> References: <201512222012.tBMKCqqg039018@repo.freebsd.org> <20151223073258.M993@besplex.bde.org> <20151224205730.GC3625@kib.kiev.ua> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.1 cv=PfoC/XVd c=1 sm=1 tr=0 a=KA6XNC2GZCFrdESI5ZmdjQ==:117 a=PO7r1zJSAAAA:8 a=JzwRw_2MAAAA:8 a=kj9zAlcOel0A:10 a=zuGDGuoEEVfoYA-YHOMA:9 a=CjuIK1q_8ugA:10 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Dec 2015 22:05:36 -0000 On Thu, 24 Dec 2015, Konstantin Belousov wrote: > On Wed, Dec 23, 2015 at 08:02:10AM +1100, Bruce Evans wrote: >> On Tue, 22 Dec 2015, Konstantin Belousov wrote: >> >>> Log: >>> If we annoy user with the terminal output due to failed load of >>> interpreter, also show the actual error code instead of some >>> interpretation. >> >> This and nearby messages are of annoyingly low quality. They don't >> even print the program name(s). >> >> I use the following partial fixes. I forget if they print the program >> name or the interpeter name. >> >> X Index: imgact_elf.c >> X =================================================================== >> X RCS file: /home/ncvs/src/sys/kern/imgact_elf.c,v >> X retrieving revision 1.151 >> X diff -u -2 -r1.151 imgact_elf.c >> X --- imgact_elf.c 5 Jun 2004 02:18:28 -0000 1.151 >> X +++ imgact_elf.c 5 Jun 2004 06:51:25 -0000 >> X @@ -694,6 +693,6 @@ >> X brand_info = __elfN(get_brandinfo)(hdr, interp); >> X if (brand_info == NULL) { >> X - uprintf("ELF binary type \"%u\" not known.\n", >> X - hdr->e_ident[EI_OSABI]); >> X + uprintf("%s: ELF binary type \"%u\" not known.\n", >> X + imgp->stringbase, hdr->e_ident[EI_OSABI]); > This cannot be a fix. there is no stringbase member in struct imgact. There was in FreeBSD-5. > In fact, there is no available path to the executable in the image activation > routine, and due to things like fexecve(2), it may have been not passed > to the kernel at all. argv[0] and the string being interpreted must be known at some point. > The present structure of the messages is forced by this fact, and it is > usually obvious what is the image kernel complained about, since it is > the image that was just executed. Not if it is one of many commands in a script. Bruce