From nobody Thu Jun 12 02:56:21 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bHnGy0GM9z5xxNC for ; Thu, 12 Jun 2025 02:56:26 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bHnGx34Lvz3rDw for ; Thu, 12 Jun 2025 02:56:25 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-io1-xd32.google.com with SMTP id ca18e2360f4ac-872886ed65aso46193539f.1 for ; Wed, 11 Jun 2025 19:56:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; t=1749696984; x=1750301784; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=n5NmaaLdeO4IDTIoj49lnCkYAOOlLX1hI2yyAzhsmAo=; b=Fz0MbmAGS7sNqobYm1vlUEWQCCAkkJTR2qdnGRF1USiR0+W6hpgahYzwwOjChRvcs/ EA6vusufcrlNNsoIugv0+XdYAtIIdDgNHuwahBb39VxTQkIsxPmRj/w+cmXV2+CjzrmY ksEWpfy4ple+lVwNl/MU0ivp6IVcXn0mxArZ9/1brzbbdHBq2jeSOV0pUIJztG2l5cfV BA1kVunuhrT7vikRS2M6Ue+zqt7t54efKTGXJ0cZSj2IqYcdCKh+3A+v+GIqDTICim0r COoIHfbISXrJPMZUOrxq5iBJrLXFeLWW8p3OWsTk0ln+Kiw6gGv+6X/EQJcgg+lNZw5V jI9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749696984; x=1750301784; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=n5NmaaLdeO4IDTIoj49lnCkYAOOlLX1hI2yyAzhsmAo=; b=T54T4g40KKNIIOG4+Z6TFtup4KswaviroLRzjo5ChPy5VZA/3svYHOArOQ2kAvUJwL Zaul6JrQuM2q9dlhCuW3Fad2EHJEnZ5fccd0fpRn/dmVujHvRdTkbJNprBuAHrnrNUDj c773hqxoU31GqXw8MaFPcJDQKvz9H4/EwgZLGsVCoDnrXtiGg7/kVryhAYbE5NbIOeNZ E7gm+ChnQp4Spy7xyGeQm2A9zSGt6pgmL79b7eP2shwEi0iREN2MIE+C+mkX8O/KPM2g xo9WsBYMwd7rVijG2txzp9b5cqcp1Y/CZPFCk0+blezoHoCxWd3qqFcFfxX1vCgvGdI4 MBjQ== X-Forwarded-Encrypted: i=1; AJvYcCUnyKj2HnpR3zlEqFvD6S115FppYxrIxsX4mJxP7Qoyw6bjiH5K2a+iWRhC3EKIqu+oo7vdPrXdM5zC5PnkzpOMHLeI@freebsd.org X-Gm-Message-State: AOJu0Yz6cvkImnDo2g+naKtGMo4nDYCU+6IOce/EQWQaq0ofU0Ba4099 SOMWGW43NCKxwMRJyYXoEGmFHBMl9gaoRWlqYg4iYssTrSXkNKJyGnFHPNtuSjauKA8= X-Gm-Gg: ASbGncv94UtZp+6WeaXrFUEZesi6J7A+hxLyNdIFy4AKXR0UakwyTfJNvAyRyrprMEX byde7bsaeyjM6GlbMUMqC/y2vjPDRui0SgYb71f3IDPXMNaiV82/G2JuO9Se6iMyVz+cyMx+I+W kuPQKlxCmOaggE/YzsyTCv+QXy0ymnE7BSwMLGOp4J3YH9WBU4GJtP9iI4wW74AWtH+0CwOkdty 5ev4R+fxgTchhyi8kZDlk6X/WehZGlzoMS59o/xtN40Zr00vbOvSzcS/2yaHdsJPVk2nR/ZoSuM kBs5olm1synnS64qQ1T6txMOuunzmzuz7zfTJLN9QbP4 X-Google-Smtp-Source: AGHT+IH7Spsen2S26fOb73rAfbM2jqZYYrzHHLSWEl9iJlwNLjlT0/hFeSdKezi7OjDjms+TtPASIQ== X-Received: by 2002:a05:6e02:17c5:b0:3dd:ce9b:aa17 with SMTP id e9e14a558f8ab-3ddf4315263mr63584395ab.20.1749696983591; Wed, 11 Jun 2025 19:56:23 -0700 (PDT) Received: from mutt-hbsd ([2001:470:4001:1::95]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-5013b7ca57esm111524173.59.2025.06.11.19.56.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 19:56:22 -0700 (PDT) Date: Thu, 12 Jun 2025 02:56:21 +0000 From: Shawn Webb To: Warner Losh , Ricardo Branco Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 3d12567133bf - main - Add the POSIX sig2str(3) & str2sig(3) calls Message-ID: X-Operating-System: FreeBSD mutt-hbsd 14.2-STABLE-HBSD FreeBSD 14.2-STABLE-HBSD HARDENEDBSD-14-STABLE amd64 X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <202506112316.55BNGeGh046207@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hpe22asn2yxz7nsz" Content-Disposition: inline In-Reply-To: <202506112316.55BNGeGh046207@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4bHnGx34Lvz3rDw X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] --hpe22asn2yxz7nsz Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: git: 3d12567133bf - main - Add the POSIX sig2str(3) & str2sig(3) calls MIME-Version: 1.0 On Wed, Jun 11, 2025 at 11:16:40PM +0000, Warner Losh wrote: > The branch main has been updated by imp: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D3d12567133bfb4082a5115f16a= 71a865ff2af7fb >=20 > commit 3d12567133bfb4082a5115f16a71a865ff2af7fb > Author: Ricardo Branco > AuthorDate: 2025-05-10 20:56:03 +0000 > Commit: Warner Losh > CommitDate: 2025-06-11 23:16:22 +0000 >=20 > Add the POSIX sig2str(3) & str2sig(3) calls > =20 > Signed-off-by: Ricardo Branco > Reviewed by: imp, kib, des, jilles > Pull Request: https://github.com/freebsd/freebsd-src/pull/1696 > --- > include/signal.h | 9 ++++ > lib/libc/gen/Makefile.inc | 3 ++ > lib/libc/gen/Symbol.map | 2 + > lib/libc/gen/psignal.3 | 56 ++++++++++++++++++++++- > lib/libc/gen/sig2str.c | 112 ++++++++++++++++++++++++++++++++++++++++= ++++++ > 5 files changed, 180 insertions(+), 2 deletions(-) >=20 > diff --git a/include/signal.h b/include/signal.h > index c1d341f317f4..22fefb63568f 100644 > --- a/include/signal.h > +++ b/include/signal.h > @@ -40,6 +40,10 @@ > #include > #endif > =20 > +#if __POSIX_VISIBLE >=3D 202405 || __BSD_VISIBLE > +#define SIG2STR_MAX 32 /* size of buffer required for sig2str() */ > +#endif Hey Warner and Ricardo, The above breaks building world when _FORTIFY_SOURCE=3D2. I've committed in HardenedBSD a fix: https://git.hardenedbsd.org/hardenedbsd/HardenedBSD/-/commit/0572db282c5a54= 2fe0de52739932e91eade537ed I suppose that the !defined gate might not actually be desired, since doing it the way I did might cause issues if third-party code defines the macro to a value smaller than what libc was built with. I might remove that gate. Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Signal Username: shawn_webb.74 Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --hpe22asn2yxz7nsz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmhKQcMACgkQ/y5nonf4 4frPTxAAhubTBLXKz3JzOES74yOFCKtyfGx1oyslx50HVYiYJzIlfiEV8vJ8t7dH opd9gI0ENndtm8PMduEtabQArMIAGobpSux1zsfifIydGerOgZpFx1fZUj5/f5yQ V5t0E0s0ekcsQhmes6rw0jQ3NDbdQFQHNoa5zZD/ggaUeuvLked3vYC9aX2P1QDr 1PGUW0h3CrrURLp+JD+hemQKsceE9uZBnAx3cZpjVzeorbc5rULyqEbuxecJ2/Il 1b/JwyUSX9/pmuRZUhSrtit3AzuLbHxgcJoB0JdMlym5qhbuTUexRbxLDInYwN16 x/bgpVAD4N8un6Mx8yM8VMv4lX+Z6T1dmkGoxR1s+bto6/ZVxBrr2N2UXSaozzDf c90V+2lLs8eLZFsDJPJMjcWSNhkFHQtcsHd4q8PBuYIaisI/EKPakyeSj7obtTwo WS3Oqwp/FDy9i2ft4hqRdcUCPn/CoQGDwVgLjrERQBkmqcXHgq7w5CHX+SOENwt6 G5dLDb41BbeFGnxFwAV56TPv0SzYsli4f22gOtxoAu16789HIuE83j6LUFvCBa89 Gpr6g0AvJb1/A8n7atwpi3uxB2OCZ43Gq+YLnOSE2KbBHk+opsIR9Tlnry/Ylm6X MJeQy76nw1zs9L9/VR4lHt1CRrclRKzv43DQmXfcEbjvv5sn/24= =cvQ6 -----END PGP SIGNATURE----- --hpe22asn2yxz7nsz--