From owner-svn-src-head@freebsd.org Sat Nov 7 16:56:41 2015 Return-Path: <owner-svn-src-head@freebsd.org> Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0B644A28CBA; Sat, 7 Nov 2015 16:56:41 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x231.google.com (mail-wi0-x231.google.com [IPv6:2a00:1450:400c:c05::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 963C51F67; Sat, 7 Nov 2015 16:56:40 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wijp11 with SMTP id p11so46698059wij.0; Sat, 07 Nov 2015 08:56:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=q2xCqdq92yWoNFJUkJUBvYuREgdHP7/ZZkhrglhBryk=; b=VVTZqQdZEwyzaRuhBMIUXXJ12MEnFx6MBV30iqErAf2GDibvkdmP68Oo2fp2rnRaKg LezbKtHMBSiYbBozw24cAlvqftCdgXVmvdXOuTIxKnvZMtvUyffglUwwwuYewHem6tNP X15q2iS0nDlvj7F072fAdFgBSOpB9jjNf10E5HVgeM8p2U/e3iSARLpgiW2lbVJvklwN P6Je1MQS5yMYe406qWcmYES0HbmWKIpS+J+hYqkdK1gVD/LgYlIH64VpFDktjXfzcf6j hm1PzhuzE+sBVyESXrD+LEas1wANiBcl2jaFJnZFY9xYvEgSqmjbrfGjivtBqvh4B3vz n+yw== X-Received: by 10.194.249.69 with SMTP id ys5mr9764981wjc.97.1446915399073; Sat, 07 Nov 2015 08:56:39 -0800 (PST) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id r5sm329508wjf.18.2015.11.07.08.56.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Nov 2015 08:56:38 -0800 (PST) Sender: Baptiste Daroussin <baptiste.daroussin@gmail.com> Date: Sat, 7 Nov 2015 17:56:36 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Andrey Chernov <ache@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, jasone@FreeBSD.org Subject: Re: svn commit: r290499 - head/usr.bin/localedef Message-ID: <20151107165636.GA31396@ivaldir.etoilebsd.net> References: <201511071622.tA7GMTDN099727@repo.freebsd.org> <563E2BA6.9020505@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ReaqsoxgOBHFXBhH" Content-Disposition: inline In-Reply-To: <563E2BA6.9020505@freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current <svn-src-head.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>, <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/> List-Post: <mailto:svn-src-head@freebsd.org> List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>, <mailto:svn-src-head-request@freebsd.org?subject=subscribe> X-List-Received-Date: Sat, 07 Nov 2015 16:56:41 -0000 --ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 07, 2015 at 07:49:42PM +0300, Andrey Chernov wrote: > On 07.11.2015 19:22, Baptiste Daroussin wrote: > > Author: bapt > > Date: Sat Nov 7 16:22:29 2015 > > New Revision: 290499 > > URL: https://svnweb.freebsd.org/changeset/base/290499 > >=20 > > Log: > > Workaround an issue on i386 to unbreak the build until the real issue= is tracked > > down > > - large =3D calloc(sizeof (collate_large_t) * n, 1); > > + large =3D malloc(sizeof (collate_large_t) * n); > > + memset(large, 0, sizeof (collate_large_t) * n); >=20 > Should be calloc(n, sizeof (collate_large_t)) according to calloc usage > and to prevent size_t overflow. Is it calloc() bug? I have tried all combinaison with calloc before committing the workaround, = all fails the same way on i386: <jemalloc>: jemalloc_arena.c:353: Failed assertion: "p[i] =3D=3D 0" So yes I'm thinking about a calloc bug (Jason CCed) FYI sizeof(collate_large_t) is 44 there and n is 1145 Best regards, Bapt --ReaqsoxgOBHFXBhH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlY+LUQACgkQ8kTtMUmk6Ewl9QCgnfCjkV77VCdYqHVOfXL042pP ElQAn0qAVxekWG103NuWoLmvsR8HNuD8 =I67P -----END PGP SIGNATURE----- --ReaqsoxgOBHFXBhH--