From owner-svn-src-all@FreeBSD.ORG Sat May 11 00:06:59 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id F0285BDD; Sat, 11 May 2013 00:06:58 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-ie0-x22a.google.com (mail-ie0-x22a.google.com [IPv6:2607:f8b0:4001:c03::22a]) by mx1.freebsd.org (Postfix) with ESMTP id 9DADBF57; Sat, 11 May 2013 00:06:58 +0000 (UTC) Received: by mail-ie0-f170.google.com with SMTP id aq17so9308858iec.1 for ; Fri, 10 May 2013 17:06:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=0SOTlhGd+u8RWRysoZu6OJyyDk3yuADcojnyP2svqx0=; b=gPFUYOwqfdW7gmo+/mr3XffXoTFyXZ8dlZ/PvubAvHyR7gMkvA+WVVQheg6j4T4MVr TE+GpHxBVQG81AudqcFmnyYL4Z1QtMKz8VgutO9Th+IS/P8WRZpk2I1+ZaX5Fr9MyHxC Rzifp6ZBu02RoyAYp6F7WoTxhXaNP14I003QvygeaJ9ywftc1mOTMwXM/a42TNqy46nw RiOHQpNRBqYSFdyBTb3w9nvy2D+jbfWbXIrLluqmVlna2XieQj8A5c9lDxz/JCPjEXDZ YeEmXcIT9REmGMg42/qBwiq5Y7Wirhz7K8Oy8o8d5I9IW1OT+2ka7m1oqD7lLWCjgLLe H96w== X-Received: by 10.43.133.134 with SMTP id hy6mr5291873icc.57.1368230818399; Fri, 10 May 2013 17:06:58 -0700 (PDT) Received: from gloom ([216.58.1.190]) by mx.google.com with ESMTPSA id xf4sm1253618igb.8.2013.05.10.17.06.56 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 10 May 2013 17:06:57 -0700 (PDT) Sender: Mark Johnston Date: Fri, 10 May 2013 20:06:51 -0400 From: Mark Johnston To: Glen Barber Subject: Re: svn commit: r250479 - stable/8/usr.sbin/newsyslog Message-ID: <20130511000651.GA1759@gloom> References: <201305102056.r4AKu7h7047000@svn.freebsd.org> <20130510234147.GC1651@glenbarber.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130510234147.GC1651@glenbarber.us> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 May 2013 00:06:59 -0000 On Fri, May 10, 2013 at 07:41:47PM -0400, Glen Barber wrote: > On Fri, May 10, 2013 at 08:56:07PM +0000, Mark Johnston wrote: > > Author: markj > > Date: Fri May 10 20:56:07 2013 > > New Revision: 250479 > > URL: http://svnweb.freebsd.org/changeset/base/250479 > > > > Log: > > MFC r248776: > > Fix interval-based rotations when the -t flag is used. In this case, find > > the most-recently archived logfile and use its mtime to determine whether > > or not to rotate, as in the non-timestamped case. > > > > Previously we would just try to use the mtime of .0, which always > > results in a rotation since it generally doesn't exist in the -t case. > > > > Approved by: emaste > > > > Modified: > > stable/8/usr.sbin/newsyslog/newsyslog.c > > Directory Properties: > > stable/8/usr.sbin/newsyslog/ (props changed) > > > > I think this commit breaks stable/8 for at least mips and arm. > > http://tinderbox.freebsd.org/tinderbox-freebsd8-build-RELENG_8-mips-mips.full > > Glen > I'm very sorry about that. :( I've fixed the problem in r250489 and r250490.