From owner-cvs-all@FreeBSD.ORG Tue Jun 3 07:46:28 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3438737B407; Tue, 3 Jun 2003 07:46:28 -0700 (PDT) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8408943FA3; Tue, 3 Jun 2003 07:46:25 -0700 (PDT) (envelope-from sam@errno.com) Received: from melange (melange.errno.com [66.127.85.82]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.9) with ESMTP id h53EkOpw077321 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Tue, 3 Jun 2003 07:46:25 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <088401c329de$e82f7a50$52557f42@errno.com> From: "Sam Leffler" To: "Nate Lawson" References: <20030602233211.2492D37B4A2@hub.freebsd.org> <20030602234329.T22029@root.org> Date: Tue, 3 Jun 2003 07:46:23 -0700 Organization: Errno Consulting MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4920.2300 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4920.2300 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ubsec ubsec.c ubsecvar.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jun 2003 14:46:28 -0000 > On Mon, 2 Jun 2003, Sam Leffler wrote: > > Redo locking for proper SMP operation: > > > > o replace driver-global lock with three locks: one for the handling of mcr1 > > operations, one for handling of mcr2 operations, and one for the mcr1 > > free list > > o mark the interrupt handler MPSAFE > > o don't use locking on detach; disabling interrupts is sufficient (I think) > > Unfortunately it's not if you're on a shared interrupt. You need to > call bus_teardown_intr() before you are detached from the ithread. See > the thread near this message: > Message-ID: <1742240000.1051807110@aslan.btc.adaptec.com> If you're interested look at the change. I understood the device could be on a shared irq. Sam