From owner-freebsd-usb@FreeBSD.ORG  Sat Nov  5 12:10:13 2011
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 65F1D1065673
	for <freebsd-usb@hub.freebsd.org>; Sat,  5 Nov 2011 12:10:13 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 555428FC12
	for <freebsd-usb@hub.freebsd.org>; Sat,  5 Nov 2011 12:10:13 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id pA5CADh6088390
	for <freebsd-usb@freefall.freebsd.org>; Sat, 5 Nov 2011 12:10:13 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id pA5CADP0088389;
	Sat, 5 Nov 2011 12:10:13 GMT (envelope-from gnats)
Date: Sat, 5 Nov 2011 12:10:13 GMT
Message-Id: <201111051210.pA5CADP0088389@freefall.freebsd.org>
To: freebsd-usb@FreeBSD.org
From: Hans Petter Selasky <hselasky@c2i.net>
Cc: 
Subject: Re: usb/162307: [uslcom][patch] cp2103 usb-to-serial driver does
	not support modem control lines
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Hans Petter Selasky <hselasky@c2i.net>
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Nov 2011 12:10:13 -0000

The following reply was made to PR usb/162307; it has been noted by GNATS.

From: Hans Petter Selasky <hselasky@c2i.net>
To: freebsd-usb@freebsd.org
Cc: JD Louw <jl@nanoteq.com>,
 freebsd-gnats-submit@freebsd.org
Subject: Re: usb/162307: [uslcom][patch] cp2103 usb-to-serial driver does not support modem control lines
Date: Sat, 5 Nov 2011 13:02:05 +0100

 On Saturday 05 November 2011 11:51:14 JD Louw wrote:
 > usb/162307
 
 Committed with some modifications:
 
 1) control transfers automatically clear-stall.
 2) control transfers should have a timeout
 3) flowcontrol[2,3] must be zeroed
 4) flowcontrol must be stored in little endian format
 5) reduce the interval a little bit, because it is blocking other control 
 transfers to this device.
 6) reduce control transfer buffer to the request plus 8 bytes, of which only 1 
 byte is used.
 
 Please verify and check that my modifications to your patch are correct:
 http://svn.freebsd.org/changeset/base/227108
 
 Thanks for the patch!
 
 --HPS