From nobody Mon Oct 16 13:12:49 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S8HbP6MHkz4xM0N for ; Mon, 16 Oct 2023 13:12:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S8HbP5Jslz4G0w for ; Mon, 16 Oct 2023 13:12:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697461969; a=rsa-sha256; cv=none; b=iZ9wjtz9t+KfWuB3giAdCQpoDBgo9juZKD/2CSV3kcbIPZqGTBhfvXM4BUh8QgRtT6sC9a 3LMvpkoXI2IyAjpDZu/1Fc0mtmb+dmiXsvq9Dn8uH0MAIOHNtfpvrjLHb/GrSlsS1ibKzi GKBct/83QNPFh5NpLPr7VrjdsqlVWqHmOUKGvmBgWPeOmGyEUp5eHpSFdvCPAognKFrErg m5xSgXlXjTAeEGmV+gZzvNMX3WV4oaP0PWwDvq20PpxVhDFhXaRbXwaoq2EyWJ35wVtHXV cw3a3CbL6uTvexT9SVJJaqkgXo3VxEInYRUwX/0Tr+Y1bzQBxo+gphFdYBfBig== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697461969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t2KRWYnnWvqxGms6Ey7lMbwY7a720J/f2eq32dgKoMc=; b=lzcv5a/icGPQsTdLN9BaxRuLGZ8gsp4xn4XoW6Yt8ap1SeRCZnG5wOcDREFyxrncMREIgH juPn9wOFxzeFLFmDCuN0v6mefgAj+8zMft3CQxhHbTYnhk+EALXxzL1O9I0SKsxbab+IYe 2i1c2eIm7kyKOwb9J079dyJGw2f4POmNQKVDpomxoOVSBh8+bkjTKX9/vONBAIkTB7/PQu U7Ut1MDlsKiy9VhrlPPrRW2lgNW2N/gSwC73xwcd5DXsdDOpNcuCuxu9Sq1smPF2dC8sRL wi6OMxlQz2J1/fmAxkRqif689tjfjCq+i91LYN4PSLxMX3KALIQDmL5qd/efxw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S8HbP4PzRzhFc for ; Mon, 16 Oct 2023 13:12:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 39GDCnPZ053148 for ; Mon, 16 Oct 2023 13:12:49 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 39GDCn1j053147 for bugs@FreeBSD.org; Mon, 16 Oct 2023 13:12:49 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 274454] usr.sbin/syslogd: closing a configured terminal in parse_action(), line 3057 Date: Mon, 16 Oct 2023 13:12:49 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274454 --- Comment #9 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dd556719e15d643ba9619bbbeab550eed8= 7614525 commit d556719e15d643ba9619bbbeab550eed87614525 Author: Jake Freeland AuthorDate: 2023-10-15 20:34:06 +0000 Commit: Mark Johnston CommitDate: 2023-10-16 13:11:58 +0000 syslogd: Keep console and tty descriptors open Console and tty descriptors are initially opened in parse_action() to determine whether they are valid using isatty(). That descriptor is then closed because it is never accessed by syslogd again; ttymsg() will reo= pen the tty/console under a new descriptor when needed. If the user attempts to log to a tty that is inactive outside of syslogd, then syslogd must keep that descriptor open so the tty remains accessible. For example, logging to `/dev/ttyvb` requires the initial `/dev/ttyvb` descriptor to stay open so the user can view its buffer at any time via CTRL+ALT+F12. As a result, console and tty descriptors must remain open until a potential configuration reload or a system shutdown. The given descriptor will be closed in close_filed() in such circumstances. PR: 274454 Fixes: c3175a6e1c5a ("syslogd: Do not open console descriptor") Reported by: Trond Endrest=C3=B8l Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D42215 usr.sbin/syslogd/syslogd.c | 3 --- 1 file changed, 3 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=