From owner-freebsd-current@FreeBSD.ORG Wed Sep 3 15:26:11 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 68E1F16A4BF for ; Wed, 3 Sep 2003 15:26:11 -0700 (PDT) Received: from mail.liwing.de (mail.liwing.de [213.70.188.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 026B043FBF for ; Wed, 3 Sep 2003 15:26:10 -0700 (PDT) (envelope-from rehsack@liwing.de) Received: (qmail 64240 invoked from network); 3 Sep 2003 22:26:00 -0000 Received: from stingray.liwing.de (HELO liwing.de) ([213.70.188.164]) (envelope-sender ) by mail.liwing.de (qmail-ldap-1.03) with SMTP for ; 3 Sep 2003 22:26:00 -0000 Message-ID: <3F566A78.1070705@liwing.de> Date: Wed, 03 Sep 2003 22:26:00 +0000 From: Jens Rehsack User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.4) Gecko/20030821 X-Accept-Language: de-de, de, en-us, en MIME-Version: 1.0 To: John-Mark Gurney References: <3F56651C.5050108@liwing.de> <20030903220756.GG16766@funkthat.com> In-Reply-To: <20030903220756.GG16766@funkthat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: roger@freebsd.org cc: Michal Mertl cc: current@freebsd.org Subject: Re: bktr(4) bufs plus patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Sep 2003 22:26:11 -0000 John-Mark Gurney wrote: > Jens Rehsack wrote this message on Wed, Sep 03, 2003 at 22:03 +0000: > >>Michal Mertl wrote: >> >>>I found 2 bugs and some potential problems in bktr(4) code. >>> >>>Bug 1: >>>Compilation with options BKTR_USE_FREEBSD_SMBUS failes. Error is >>>that code tries to use iicbus which isn't defined where it looks for >>>it. I added it there and the compilation and detection goes fine. I don't >>>know how to actually test it though. >>> >> >>[...] >> >>Will anyone responsible take notice of this patch and commit it? > > > I'm not responsible, but I will take notice of it. Once I get my lab > up and running (hopefully in the next week), I can test this and see how > it works. Could we get it submitted as a pr (if it isn't already), and > assign it to me? (I'll assign it to myself once I know the PR). > This should be done by Michal, because it's the original submitter and seems to have made deep research :-) Jens