From owner-svn-src-all@freebsd.org Tue Aug 11 13:55:15 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2D6FF99ED56; Tue, 11 Aug 2015 13:55:15 +0000 (UTC) (envelope-from kwm@freebsd.org) Received: from fep31.mx.upcmail.net (fep31.mx.upcmail.net [62.179.121.49]) by mx1.freebsd.org (Postfix) with ESMTP id DADA2A3A; Tue, 11 Aug 2015 13:55:13 +0000 (UTC) (envelope-from kwm@freebsd.org) Received: from edge04.upcmail.net ([192.168.13.239]) by viefep31-int.chello.at (InterMail vM.8.01.05.05 201-2260-151-110-20120111) with ESMTP id <20150811134651.ZLSS812.viefep31-int.chello.at@edge04.upcmail.net>; Tue, 11 Aug 2015 15:46:51 +0200 Received: from [192.168.1.60] ([95.96.229.21]) by edge04.upcmail.net with edge id 3Rv31r00a0ULilr01Rv3Rd; Tue, 11 Aug 2015 15:55:04 +0200 X-SourceIP: 95.96.229.21 Message-ID: <1439301209.4375.40.camel@FreeBSD.org> Subject: Re: svn commit: r286524 - in head: . etc sys/dev/drm sys/dev/drm2 From: Koop Mast To: Jan Beich Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Date: Tue, 11 Aug 2015 15:53:29 +0200 In-Reply-To: References: <201508091258.t79CwvGj027161@repo.freebsd.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.4 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Aug 2015 13:55:15 -0000 On Mon, 2015-08-10 at 02:15 +0200, Jan Beich wrote: > Koop Mast writes: > > > Author: kwm (ports committer) > > Date: Sun Aug 9 12:58:56 2015 > > New Revision: 286524 > > URL: https://svnweb.freebsd.org/changeset/base/286524 > > > > Log: > > Add a new group named 'video' with the id of 44. And make drm > > create > > devices in /dev/dri/ with this new group. > > Would 'video' group include capture devices as well? Linux seems to > mix > /dev/nvidia*, /dev/fb* and /dev/video* all under same group despite > all of them have different attack vectors. We could extend this, but the only example I had where the dri devices. Also webcamd already chmod's it's devices: % ll /dev/video0 crw-rw---- 1 webcamd webcamd 0x9a Aug 10 07:35 /dev/video0 I'm unsure if nvidia makes any /dev devices since it been ages since I had one in a machine of mine. > > Modified: head/sys/dev/drm/drmP.h > > =================================================================== > > =========== > > --- head/sys/dev/drm/drmP.h Sun Aug 9 12:20:22 2015 > > (r286523) > > +++ head/sys/dev/drm/drmP.h Sun Aug 9 12:58:56 2015 > > (r286524) > > @@ -175,7 +175,7 @@ SYSCTL_DECL(_hw_drm); > > > > #define DRM_DEV_MODE (S_IRUSR|S_IWUSR|S_IRGRP|S_IWGRP) > > #define DRM_DEV_UID 0 > > -#define DRM_DEV_GID 0 > > +#define DRM_DEV_GID 44 /* "video" group */ > > Why hardcode? Linux often uses udev(7) rules to assign a group which > on > FreeBSD can easily be translated into devd.conf(5) or devfs.rules(5). > > Having 'video' assigned by kernel wouldn't eliminate having to run > mergemaster/etcupdate + pw groupmod on upgrade. I find this way easier to do. However with the devd.conf(5) or devfs.rules(5) someone still needs to up date the /etc and pw groupmod. -Koop