From owner-dev-commits-src-main@freebsd.org Sat Sep 18 01:43:42 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3417466ED57 for ; Sat, 18 Sep 2021 01:43:42 +0000 (UTC) (envelope-from me@cameronkatri.com) Received: from cameronkatri.com (cameronkatri.com [206.189.178.249]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4HBDB52LW2z4tsK for ; Sat, 18 Sep 2021 01:43:41 +0000 (UTC) (envelope-from me@cameronkatri.com) Received: from FreeBSDY540 (c-73-84-80-103.hsd1.fl.comcast.net [73.84.80.103]) by cameronkatri.com (Postfix) with ESMTPSA id 2FBCD41448 for ; Fri, 17 Sep 2021 21:43:35 -0400 (EDT) Date: Fri, 17 Sep 2021 21:43:34 -0400 From: Cameron Katri To: dev-commits-src-main@freebsd.org Subject: Re: git: 021385aba562 - main - Add WITH_LLVM_BINUTILS to install LLVM binutils instead of Elftoolchain Message-ID: <20210918014334.zkjlq7q65nnotm4k@FreeBSDY540> References: <202109060924.1869O2Dk045877@gitrepo.freebsd.org> <20210911144340.pmpxca7obksc7v5g@mutt-hbsd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zud3myv4n2jc6ejy" Content-Disposition: inline In-Reply-To: <20210911144340.pmpxca7obksc7v5g@mutt-hbsd> X-Rspamd-Queue-Id: 4HBDB52LW2z4tsK X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.59 / 15.00]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[cameronkatri.com:s=20201109]; FREEFALL_USER(0.00)[me]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[cameronkatri.com:+]; DMARC_POLICY_ALLOW(-0.50)[cameronkatri.com,reject]; NEURAL_HAM_SHORT(-0.99)[-0.994]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; MID_RHS_NOT_FQDN(0.50)[]; ASN(0.00)[asn:14061, ipnet:206.189.176.0/20, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[dev-commits-src-main]; RECEIVED_SPAMHAUS_PBL(0.00)[73.84.80.103:received] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Sep 2021 01:43:42 -0000 --zud3myv4n2jc6ejy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 11, 2021 at 10:43:40AM -0400, Shawn Webb wrote: > On Mon, Sep 06, 2021 at 09:24:02AM +0000, Alex Richardson wrote: > > The branch main has been updated by arichardson: > >=20 > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D021385aba56279febcfdcc64= d23673a0106ae45d > >=20 > > commit 021385aba56279febcfdcc64d23673a0106ae45d > > Author: Alex Richardson > > AuthorDate: 2021-09-06 08:49:49 +0000 > > Commit: Alex Richardson > > CommitDate: 2021-09-06 08:49:49 +0000 > >=20 > > Add WITH_LLVM_BINUTILS to install LLVM binutils instead of Elftoolc= hain > > =20 > > When WITH_LLVM_BINUTILS is set, we will install the LLVM binutils as > > ar/ranlib/nm/objcopy/etc. instead of the elftoolchain ones. > > Having the LLVM binutils instead of the elftoolchain ones allows us= to use > > features such as LTO that depend on binutils that understand LLVM I= R. > > Another benefit will be an improved user-experience when compiling = with > > AddressSanitizer, since ASAN does not symbolize backtraces correctl= y if > > addr2line is elftoolchain addr2line instead of llvm-symbolizer. > > See https://lists.freebsd.org/archives/freebsd-toolchain/2021-July/= 000062.html > > for more details. > > =20 > > This is currently off by default but will be turned on by default a= t some > > point in the near future. >=20 > Hey Alex, >=20 > It appears when MK_LLVM_BINUTILS is set, a strip binary/link doesn't > get installed. So /usr/bin/strip doesn't exist. This causes a problem > when building packages since even ports-mgmt/pkg relies on strip. >=20 > I'm working on a candidate patch to fix this right now. But if you > beat me to the punch, all the better. ;-) >=20 > Thanks, >=20 > --=20 > Shawn Webb > Cofounder / Security Engineer > HardenedBSD >=20 > https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/0= 3A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc Hello, I just noticed that strings is still the elftoolchain version, and llvm-readelf is not connected to the buildsystem at all. - Cameron Katri --=20 Cameron Katri Email: me@cameronkatri.com PGP Fingerprint: 7D3B36CEA40FCC2181FB6DCDBAFFD97826540F1C --zud3myv4n2jc6ejy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEfTs2zqQPzCGB+23Nuv/ZeCZUDxwFAmFFREYACgkQuv/ZeCZU DxyJGgf/Qc02c5g0AMIsjxC8eDnRTMSzx+oPkxp5hPWSZkaOOb+Kx/8r0pDrx0gl yBTQFbTOsdHPICjgrFThP/ltpRiWdLlPafs4iYw8e0KkDodb/penrtvz7/3s6zc1 sIvg02Nh1fQSeCCdKGB3XSbWQhIJCh3qsH0SD3bw0w61D6L8fAu4vqkHK+ZIhMFa ew93UY031UbWCZFAKXuiGx2v81XN1N9oVfw1mVG/RQBjb138lPCnqn7RraPB+HCA kh563sf18Uiqfdiu6cd12WDN1pWK7IozztqtwlM1Yc3NaK/Zt8TeThuV5IYqeLSW RsMB0Dg08JWp5/MwPwH+P/oEdx9rZQ== =W8Ba -----END PGP SIGNATURE----- --zud3myv4n2jc6ejy--