From owner-p4-projects@FreeBSD.ORG  Thu May  1 06:55:51 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id B7E1837B404; Thu,  1 May 2003 06:55:50 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 539AD37B401
	for <perforce@freebsd.org>; Thu,  1 May 2003 06:55:50 -0700 (PDT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0063943F3F
	for <perforce@freebsd.org>; Thu,  1 May 2003 06:55:50 -0700 (PDT)
	(envelope-from jhb@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h41Dtn0U054343
	for <perforce@freebsd.org>; Thu, 1 May 2003 06:55:49 -0700 (PDT)
	(envelope-from jhb@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h41DtnHY054340
	for perforce@freebsd.org; Thu, 1 May 2003 06:55:49 -0700 (PDT)
Date: Thu, 1 May 2003 06:55:49 -0700 (PDT)
Message-Id: <200305011355.h41DtnHY054340@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jhb@freebsd.org using -f
From: John Baldwin <jhb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 30304 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 May 2003 13:55:51 -0000

http://perforce.freebsd.org/chv.cgi?CH=30304

Change 30304 by jhb@jhb_laptop on 2003/05/01 06:55:24

	Replace printf with an appropriate KASSERT().

Affected files ...

.. //depot/projects/smpng/sys/kern/kern_lock.c#26 edit

Differences ...

==== //depot/projects/smpng/sys/kern/kern_lock.c#26 (text+ko) ====

@@ -265,12 +265,9 @@
 		 */
 		if (lkp->lk_lockholder != thr) {
 			lockflags = LK_HAVE_EXCL;
-#ifdef INVARIANTS
-			if (td != NULL && td != curthread)
-				printf("%s: weird thread pid %d (%s)\n",
-				    __func__, td->td_proc->p_pid,
-				    td->td_proc->p_comm);
-#endif
+			KASSERT(td == NULL || td == &thread0 ||
+			    td == curthread, ("%s: bogus thread pid %d",
+			    __func__, td->td_proc->p_pid));
 			if (td != NULL && !(td->td_flags & TDF_DEADLKTREAT))
 				lockflags |= LK_WANT_EXCL | LK_WANT_UPGRADE;
 			error = acquire(&lkp, extflags, lockflags);