Date: Tue, 10 Mar 2020 14:44:36 -0300 From: Joseph Mingrone <jrm@FreeBSD.org> To: Christoph Moench-Tegeder <cmt@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r528101 - head/www/chromium/files Message-ID: <86a74o9kaj.fsf@phe.ftfl.ca> In-Reply-To: <867dzth4sp.fsf@phe.ftfl.ca> (Joseph Mingrone's message of "Mon, 09 Mar 2020 13:27:34 -0300") References: <202003091025.029APj0B094272@repo.freebsd.org> <867dzth4sp.fsf@phe.ftfl.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-= Content-Type: text/plain Joseph Mingrone <jrm@FreeBSD.org> writes: > Christoph Moench-Tegeder <cmt@FreeBSD.org> writes: >> Author: cmt >> Date: Mon Mar 9 10:25:45 2020 >> New Revision: 528101 >> URL: https://svnweb.freebsd.org/changeset/ports/528101 >> Log: >> remove patches obviously forgotten when updating to chrome 80 >> these patches don't apply anymore and are not needed anymore, according >> to my reading of the code >> PR: 244625 >> Approved by: "trivial build fixes" blanket >> Deleted: >> head/www/chromium/files/patch-base_memory_protected__memory__posix.cc >> head/www/chromium/files/patch-chrome_browser_browser__features.cc >> head/www/chromium/files/patch-chrome_browser_browser__features.h >> head/www/chromium/files/patch-chrome_browser_platform__util.h >> head/www/chromium/files/patch-content_public_app_v8__snapshot__overlay__manifest.cc >> head/www/chromium/files/patch-content_renderer_media_webrtc_webrtc__audio__renderer__unittest.cc >> head/www/chromium/files/patch-media_gpu_libyuv__image__processor.cc >> head/www/chromium/files/patch-remoting_webapp_base_js_platform.js >> head/www/chromium/files/patch-services_device_time__zone__monitor_time__zone__monitor.cc >> head/www/chromium/files/patch-ui_gl_gl__surface__glx.cc >> head/www/chromium/files/patch-ui_platform__window_platform__window__delegate.h >> head/www/chromium/files/patch-v8_src_trap-handler_handler-inside-posix.cc >> head/www/chromium/files/patch-v8_src_trap-handler_handler-inside-posix.h >> head/www/chromium/files/patch-v8_src_trap-handler_trap-handler.h > I do now see that r528072/528087 fail at the patch stage, but I'm not > exactly clear how the problem crept in [1]. > In any case, thanks for fixing. > [1] `arc patch D23984` and poudriere testport` didn't show any problems. > It seems you can't `arc patch` after the revision is closed, but I > downloaded the patch then reverted and patched my ports tree and hit the > problem. I'm out of time now, but I'll try to solve the mystery later. I don't see anything in Phabricator's web interface, but by messing with the URLs from the Phabricator emails, one can see older versions [1] of Phabricator Differentials by supplying ?id=xxx. https://reviews.freebsd.org/D23984?id=69293 shows that the patch files above were deleted in the review, but the differential gets updated with what was committed. This caused me some confusion, so I thought it might be useful to share. [1] Unsure if Phabricator has a standard term for this --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKkBAEBCgCOFiEEVbCTpybDiFVxIrrVNqQMg7DW754FAl5n0gRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUQHGpybUBmcmVl YnNkLm9yZwAKCRA2pAyDsNbvnsm9EACqixPaawtK7zhRHeZ2ANSSU6E/x1ClOOvj G5rJcpJInjW4aZNtt6xKff2nhSwKiVhruuvWXckrf76jZM4Qu2FBRwdsO5SfcAfk TwWIzJd8e10LT96Ep9zD2Rkc/qn9lXQAKFrSSGs8bU0Be/L8PFgf/W4SvpBNTr5R 0pIZyVG9P5zOMiU9Qm/BWHXs25Y8R7j3u88UODp7lBnHDKK2ZW3YOMQ49jj2/NBC S2cZ17AXjcLFP4lNYpBRcER5XnSZ1vqPIdiFVpk9Z6BJ8KV9qKchg4uaZ0CfiIkP oGQP1RdPGErMUxSmoD3QazBa7muA1CS50ibfT1FbpROGlkQH/ek5nK+KYbSuYhh3 1dOV/UNPEwJ+w04/hd5jOP0LpLlo14TEw+fhozOoDC/2iMCk4dLFT8DtnZSNyOIG 7EBKU9gbGOKt/q/W+ooByk2buexyBLxB2MA7g/J183355HP9pq9aLHLBqI7vGB0/ 9Ih4guqMoZP6XBHWE7WYcbMfXGYFkeaZJD0WT/iLRu7zM3B1Jm6bGVYp8bq1+rWh ET3XL667KNtiSzkCZblo/FtfI4h58J842OylcJXvjuyMPedbhtGsJ0NX3Wk4u8lm C2SyBgSYmpWq4ayHFcKEEKqukFEx47dHJceTuFcSgLJP0Gqc7TOiSaTqmyXhgn9t Y+pypzjz4g== =LVyJ -----END PGP SIGNATURE----- --=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86a74o9kaj.fsf>