Date: Mon, 6 Sep 2004 01:31:08 +0800 (CST) From: Yen-Ming Lee <leeym@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Cc: marcus@FreeBSD.org Subject: ports/71405: [PATCH] devel/portlint: check DATADIR and MAN3PREFIX Message-ID: <20040905173108.8A00D3EAD9F@utopia.leeym.com> Resent-Message-ID: <200409051740.i85HeMjn039196@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 71405
>Category: ports
>Synopsis: [PATCH] devel/portlint: check DATADIR and MAN3PREFIX
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sun Sep 05 17:40:22 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator: Yen-Ming Lee
>Release: FreeBSD 5.3-BETA3 i386
>Organization:
FreeBSD Taiwan
>Environment:
System: FreeBSD utopia.leeym.com 5.3-BETA3 FreeBSD 5.3-BETA3 #1: Sun Sep 5 01:06:46 CST
>Description:
This PR obsolete ports/71361.
Noticed by: mharo
- add check for DATADIR in PLIST.
- check MAN3PREFIX when PERL_CONFIGURE is set.
- bump PORTREVISION
Port maintainer (marcus@FreeBSD.org) is cc'd.
Generated with FreeBSD Port Tools 0.63
>How-To-Repeat:
>Fix:
--- portlint-2.6.7_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/devel/portlint/Makefile,v
retrieving revision 1.82
diff -u -u -r1.82 Makefile
--- Makefile 1 Sep 2004 04:13:32 -0000 1.82
+++ Makefile 5 Sep 2004 17:28:43 -0000
@@ -9,6 +9,7 @@
PORTNAME= portlint
PORTVERSION= 2.6.7
+PORTREVISION= 1
CATEGORIES= devel
MASTER_SITES= # none
DISTFILES= # none
Index: src/portlint.pl
===================================================================
RCS file: /home/pcvs/ports/devel/portlint/src/portlint.pl,v
retrieving revision 1.63
diff -u -u -r1.63 portlint.pl
--- src/portlint.pl 1 Sep 2004 04:13:32 -0000 1.63
+++ src/portlint.pl 5 Sep 2004 17:28:45 -0000
@@ -755,6 +755,10 @@
&perror("WARN: $file [$.]: consider using EXAMPLESDIR macro");
}
+ if ($_ =~ /^share\/$makevar{PORTNAME}\//) {
+ &perror("WARN: $file [$.]: consider using DATADIR macro");
+ }
+
if ($_ =~ m#man/([^/]+/)?man([$manchapters])/([^\.]+\.[$manchapters])(\.gz)?$#) {
if ($4 eq '') {
$plistman{$2} .= ' ' . $3;
@@ -2200,6 +2204,12 @@
if ($tmp =~ /MAN\U$i\E=\s*([^\n]*)\n/) {
print "OK: Makefile MAN\U$i\E=$1\n" if ($verbose);
}
+ }
+ if ($tmp =~ /PERL_CONFIGURE=\s*/
+ && $tmp =~ /MAN3PREFIX=\s*\${PREFIX}\/lib\/perl5\/\${PERL_VERSION}/) {
+ &perror("WARN: $file: MAN3PREFIX is ".
+ "\"\${PREFIX}/lib/perl5/\${PERL_VERSION}\" ".
+ "when PERL_CONFIGURE is set. you don't need to specify it.");
}
foreach my $i (split(//, $manchapters)) {
next if ($i eq '');
--- portlint-2.6.7_1.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040905173108.8A00D3EAD9F>