From owner-freebsd-office@freebsd.org Tue Feb 19 17:05:39 2019 Return-Path: Delivered-To: freebsd-office@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0B6BE14F5BB9 for ; Tue, 19 Feb 2019 17:05:39 +0000 (UTC) (envelope-from freebsd@gregv.net) Received: from aurora.gregv.net (aurora.gregv.net [192.111.144.138]) by mx1.freebsd.org (Postfix) with ESMTP id 32A568E537; Tue, 19 Feb 2019 17:05:27 +0000 (UTC) (envelope-from freebsd@gregv.net) Received: by aurora.gregv.net (Postfix, from userid 1001) id DCCB161FD3; Tue, 19 Feb 2019 12:05:20 -0500 (EST) Date: Tue, 19 Feb 2019 12:05:20 -0500 From: Greg Veldman To: Li-Wen Hsu Cc: freebsd-office@freebsd.org, Greg V , Jung-uk Kim , Justin Hibbits Subject: Re: [call for help] libreoffice 6.2 update Message-ID: <20190219170520.GC98237@aurora.gregv.net> References: <20190218144218.GA98237@aurora.gregv.net> <20190218150917.GB98237@aurora.gregv.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) X-Rspamd-Queue-Id: 32A568E537 X-Spamd-Bar: ++++ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [4.42 / 15.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.98)[0.985,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[gregv.net]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(1.00)[1.000,0]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[mail.gregv.net]; NEURAL_SPAM_LONG(0.99)[0.993,0]; R_SPF_NA(0.00)[]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; ASN(0.00)[asn:31863, ipnet:192.111.144.0/20, country:US]; IP_SCORE(0.46)[asn: 31863(2.35), country: US(-0.07)] X-BeenThere: freebsd-office@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Office applications on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Feb 2019 17:05:39 -0000 On Tue, Feb 19, 2019 at 02:50:15AM +0900, Li-Wen Hsu wrote: > Thanks very much for the help! Dropping these patches and focusing on > the supported FreeBSD versions sounds very reasonable to me. OK, I have a clean build, and I've pushed my changes up to your GitHub repo. Highlights include: - bump to 6.2.1.1 - remove patch-bridges_source_cpp__uno_gcc3__linux__intel_share.hxx and patch-bridges_source_cpp__uno_gcc3__linux__intel_uno2cpp.cxx as these appear to be primarily for building on now-unsupported FreeBSD versions - update graphics/libetonyek01 to use mdds-1.4 - in commit c53de0f of your repo, it appears you're trying to update the Makefile to account for the fact that emojione-color-font is now deprecated - I updated to reflect the fact that twemoji-color-font does not provide that file but instead provides TwitterColorEmoji-SVGinOT.ttf - in commit d4d3766 of upstream LibreOffice, several variables in sal/osl/unx/thread.cxx were declared to be const. However in function osl_thread_priority_init_Impl() they are assigned values based on the return of various sched_get_priority_*() functions. I'm not a C++ expert, but I believe this to be an upstream bug. Note that on Linux all of this code is skipped due to the definition of NO_PTHREAD_PRIORITY in sal/osl/unx/system.hxx, so the compiler error wouldn't show up. For now I've reverted that part of the commit. If there's a cleaner way to do this, let me know. If you agree it's actually a bug, I'll submit it upstream. I've tested that these changes build/run on my 11.2 box. I'll try on some other systems as I have time, but I wanted to get the changes I've been working on pushed back up to your repo in case anyone else wants to take a look, and also to protect against any possible loss. ;-) -- Greg Veldman