From owner-p4-projects@FreeBSD.ORG Fri Dec 8 20:01:57 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id C2AC616A492; Fri, 8 Dec 2006 20:01:57 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7BBF316A47B; Fri, 8 Dec 2006 20:01:57 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id C71A943CA7; Fri, 8 Dec 2006 20:00:56 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id kB8K1qu5082968; Fri, 8 Dec 2006 15:01:52 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Pawel Jakub Dawidek Date: Fri, 8 Dec 2006 14:53:11 -0500 User-Agent: KMail/1.9.1 References: <200612081207.kB8C74hR038904@repoman.freebsd.org> In-Reply-To: <200612081207.kB8C74hR038904@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200612081453.12227.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 08 Dec 2006 15:01:52 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2308/Fri Dec 8 11:10:24 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Perforce Change Reviews Subject: Re: PERFORCE change 111284 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2006 20:01:58 -0000 On Friday 08 December 2006 07:07, Pawel Jakub Dawidek wrote: > http://perforce.freebsd.org/chv.cgi?CH=111284 > > Change 111284 by pjd@pjd_anger on 2006/12/08 12:06:23 > > We need to pass static buffer to device_set_desc(). Or use device_set_desc_copy(). This change below won't work if you ever have 2 padlock devices with different descriptions. > Affected files ... > > .. //depot/projects/crypto/sys/crypto/via/padlock.c#3 edit > > Differences ... > > ==== //depot/projects/crypto/sys/crypto/via/padlock.c#3 (text+ko) ==== > > @@ -80,7 +80,7 @@ > static int > padlock_probe(device_t dev) > { > - char capp[256]; > + static char capp[256]; > > #if defined(__i386__) && !defined(PC98) > /* If there is no AES support, we has nothing to do here. */ > -- John Baldwin