From owner-p4-projects@FreeBSD.ORG Fri Jun 16 16:22:25 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id DF90F16A47C; Fri, 16 Jun 2006 16:22:24 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A563616A474; Fri, 16 Jun 2006 16:22:24 +0000 (UTC) (envelope-from xdivac02@stud.fit.vutbr.cz) Received: from eva.fit.vutbr.cz (eva.fit.vutbr.cz [147.229.10.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id 33A3A43D46; Fri, 16 Jun 2006 16:22:22 +0000 (GMT) (envelope-from xdivac02@stud.fit.vutbr.cz) Received: from eva.fit.vutbr.cz (localhost [127.0.0.1]) by eva.fit.vutbr.cz (envelope-from xdivac02@eva.fit.vutbr.cz) (8.13.7/8.13.7) with ESMTP id k5GGMGAs042368 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Fri, 16 Jun 2006 18:22:16 +0200 (CEST) Received: (from xdivac02@localhost) by eva.fit.vutbr.cz (8.13.7/8.13.3/Submit) id k5GGMGd1042367; Fri, 16 Jun 2006 18:22:16 +0200 (CEST) Date: Fri, 16 Jun 2006 18:22:16 +0200 From: Divacky Roman To: John Baldwin Message-ID: <20060616162216.GA42257@stud.fit.vutbr.cz> References: <200606131712.k5DHCIjF063625@repoman.freebsd.org> <200606131344.08736.jhb@freebsd.org> <20060615081925.GB34336@stud.fit.vutbr.cz> <200606151435.04624.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200606151435.04624.jhb@freebsd.org> User-Agent: Mutt/1.4.2i X-Scanned-By: MIMEDefang 2.54 on 147.229.10.14 Cc: Perforce Change Reviews Subject: Re: PERFORCE change 99144 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jun 2006 16:22:25 -0000 On Thu, Jun 15, 2006 at 02:35:04PM -0400, John Baldwin wrote: > On Thursday 15 June 2006 04:19, Divacky Roman wrote: > > On Tue, Jun 13, 2006 at 01:44:08PM -0400, John Baldwin wrote: > > > On Tuesday 13 June 2006 13:12, Roman Divacky wrote: > > > > http://perforce.freebsd.org/chv.cgi?CH=99144 > > > > > > > > Change 99144 by rdivacky@rdivacky_witten on 2006/06/13 17:12:02 > > > > > > > > Make the LINUXBASE path settable via sysctl. Useful when you have more > then > > > one linux bases > > > > installed etc. > > > > > > Since you only check the one global variable, why did you make the > sysctl's > > > try to handle per-prison paths? > > > > well... none of the per-prison variables is checkd against anywhere so I > > thought there's some magic behind and just copied the code from the other > > variables. > > > > can you explain me how this works? to me it seems either like unfinished > work > > or nonsense :) > > All the other per-prison variables are accessed via the linux_get_foo() > functions (like uname, etc.) and those functions look in the prison. However, > you are passing linux_emul_path directly to calls to kern_alternate_path() > (see the CHECKALT macros). You would have to change those macros to instead > call a linux_get_path() function that looked in the prison if you wanted > different prisons to have their own compat paths. the emul_path is used in just 3 places, 2 are in linprocfs and 1 in linuxolator I'll commit update to it, pls review it then