From owner-dev-commits-src-all@freebsd.org Fri May 21 14:46:12 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ACB3D6344A2; Fri, 21 May 2021 14:46:12 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FmqDN1LBsz4S4s; Fri, 21 May 2021 14:46:11 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.66.148.124]) by shaw.ca with ESMTPA id k6Phl4avriLmnk6PilAX5H; Fri, 21 May 2021 08:46:10 -0600 X-Authority-Analysis: v=2.4 cv=W+Nb6Tak c=1 sm=1 tr=0 ts=60a7c7b3 a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=8nJEP1OIZ-IA:10 a=5FLXtPjwQuUA:10 a=6I5d2MoRAAAA:8 a=oCJs8q-oAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=c9e1ACnJ86l144AVqQ8A:9 a=wPNLvfGTeEIA:10 a=IjZwj45LgO3ly-622nXo:22 a=qUF70SbvcHBaGhGVny9j:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 1DFC9A08; Fri, 21 May 2021 07:46:09 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.16.1/8.16.1) with ESMTP id 14LEk8kZ009266; Fri, 21 May 2021 07:46:08 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202105211446.14LEk8kZ009266@slippy.cwsent.com> X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Jessica Clarke cc: Marcin Wojtas , shawn.webb@hardenedbsd.org, Marcin Wojtas , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: af949c590bd8 - main - Disable stack gap for ntpd during build. In-reply-to: <02078965-24BE-4F23-92D5-5E8E54A0C3E7@freebsd.org> References: <202105211334.14LDYqoa004343@gitrepo.freebsd.org> <04F25FD0-7863-4AC1-A257-EF0F1EB90659@freebsd.org> <02078965-24BE-4F23-92D5-5E8E54A0C3E7@freebsd.org> Comments: In-reply-to Jessica Clarke message dated "Fri, 21 May 2021 15:15:43 +0100." Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Date: Fri, 21 May 2021 07:46:08 -0700 X-CMAE-Envelope: MS4xfPABxL12k0lLku+u3r6gRPOld04lO+I9IJyc/NvtPipNO3O5C4T30UocazY7qgC63U4IGNLi/CKtRCt4jbj/P/NuIEJKfCVpN0FSq013bazM5QELojZx nIO8HU9NPQROc8fx0vEcaNDmJQwvCzji1v3iWgY3Ei0I+6PdYVhOfh7Jb5tD0DfZsyUI1bk8M8ywBx7b1XgeFa46IisM1ZRXtOG291edrQpuCmmpsGyFKlUi soPXCz1vAxPZfcXk1iR1HQt5dNhknkIHY13qK5EQBCO+FeU71zMKH2qbTIymqwop+o7rRiu86JAqeVW2lwfRv7T530c1EheGgo0sl4ydD/BtbbWuWnREcXFc +GrlmK5LpCQvS7JeF+zlssQ48vkZlS+U5TsoFYlImB2q3Aj4CBoNfJGSfKfa1MBfKQVRWdyk X-Rspamd-Queue-Id: 4FmqDN1LBsz4S4s X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 May 2021 14:46:12 -0000 In message <02078965-24BE-4F23-92D5-5E8E54A0C3E7@freebsd.org>, Jessica Clarke w rites: > > On 21 May 2021, at 15:11, Marcin Wojtas wrote: > > > > Hi Jess > > > > pt., 21 maj 2021 o 15:39 Jessica Clarke napisał(a): > >> > >> On 21 May 2021, at 14:34, Marcin Wojtas wrote: > >>> > >>> The branch main has been updated by mw: > >>> > >>> URL: https://cgit.FreeBSD.org/src/commit/?id=af949c590bd8a00a5973b5875d7e > 0fa6832ea64a > >>> > >>> commit af949c590bd8a00a5973b5875d7e0fa6832ea64a > >>> Author: Marcin Wojtas > >>> AuthorDate: 2021-05-21 09:29:22 +0000 > >>> Commit: Marcin Wojtas > >>> CommitDate: 2021-05-21 13:33:06 +0000 > >>> > >>> Disable stack gap for ntpd during build. > >>> > >>> When starting, ntpd calls setrlimit(2) to limit maximum size of its > >>> stack. The stack limit chosen by ntpd is 200K, so when stack gap > >>> is enabled, the stack gap is larger than this limit, which results > >>> in ntpd crashing. > >> > >> Isn’t the bug that the unusable gap counts as usage? > >> > >> Jess > >> > > > > An alternative solution was submitted > > (https://reviews.freebsd.org/D29832), so that to extend the limit for > > ntpd, but eventually it was recommended to simple disable the stack > > gap for it until it's fixed upstream (see the last comment in the > > linked revision). > > That’s my point, there is nothing to “fix” upstream. NTPD uses less tha > n 200K > of stack, thus it is perfectly reasonable for it to set its limit to that. Th > e > fact that FreeBSD decides to count an arbitrary, non-deterministic amount of > additional unusable virtual address space towards that limit is not its fault > , > but a bug in FreeBSD that needs to be fixed as it’s entirely unreasonable f > or > applications to have to account for that. This latest problem is not stack gap. It is PIE. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.