Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 26 Jun 2021 07:20:21 +0200
From:      Stefan Esser <se@freebsd.org>
To:        Matthew Grooms <mgrooms@shrew.net>
Cc:        freebsd-stable@freebsd.org
Subject:   Re: arm64 stable/13 buildworld stops in bc
Message-ID:  <a47bd978-e262-8d14-153e-20921e395c06@freebsd.org>
In-Reply-To: <a6b652c9-43ef-c7cf-0483-15aea964b33a@shrew.net>
References:  <a6b652c9-43ef-c7cf-0483-15aea964b33a@shrew.net>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--ZxpIzhU4EAkz3ZgzEZ0VPUodoVfT8OJvW
Content-Type: multipart/mixed; boundary="qyEW2c5IcNZqxQf8RRzU8filg0bBcsBSM";
 protected-headers="v1"
From: Stefan Esser <se@freebsd.org>
To: Matthew Grooms <mgrooms@shrew.net>
Cc: freebsd-stable@freebsd.org
Message-ID: <a47bd978-e262-8d14-153e-20921e395c06@freebsd.org>
Subject: Re: arm64 stable/13 buildworld stops in bc
References: <a6b652c9-43ef-c7cf-0483-15aea964b33a@shrew.net>
In-Reply-To: <a6b652c9-43ef-c7cf-0483-15aea964b33a@shrew.net>

--qyEW2c5IcNZqxQf8RRzU8filg0bBcsBSM
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable

Am 26.06.21 um 04:30 schrieb Matthew Grooms:
> Hi All,
>=20
> I've been trying to build stable/13 kernel & world periodically for arm=
64 and
> either I'm not having very much luck or it's broken more times than it
> compiles. Is there an automated process that's checking builds for that=
 platform?

Hi Matthew,

there automated CI tests for all supported platforms, and if bc had faile=
d
to build there, I'd have been informed.

> Most recently, world stops building with bc ( see below ). However, tha=
t looks
> like that was last touched on June 1st. Has the build really been broke=
n since
> then? :/

Not for me ...

> --- all_subdir_usr.bin ---
> /usr/src/contrib/bc/src/program.c:515:28: error: too few arguments to f=
unction
> call, expected 3, have 2
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bc_file_puts(&vm.fout, str);=

> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ~~~~~~~~~~~~=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^
> /usr/src/contrib/bc/include/file.h:81:6: note: 'bc_file_puts' declared =
here
> void bc_file_puts(BcFile *restrict f, BcFlushType type, const char *str=
);
> =C2=A0=C2=A0=C2=A0=C2=A0 ^
This looks to me like the result of an incomplete update of the sources.

History editing has been added a few releases back and the function signa=
ture
of bc_files_puts has been changed to take 3 instead  of 2 arguments.

It looks like you got a mismatch between this header and the callers of t=
his
function. Specifically, line 515 mentioned in the error message above is =
line
517 in up-to.date sources and reads:

	bc_file_puts(&vm.fout, bc_flush_save, str);

Definitely 3 parameters there ...

See https://cgit.freebsd.org/src/tree/contrib/bc/src/program.c?h=3Dstable=
/13#n512
line 517 - that's what your program.c should look like ...

> /usr/src/contrib/bc/src/program.c:529:21: error: too few arguments to f=
unction
> call, expected 2, have 1
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 bc_vm_putchar('\0');
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 ~~~~~~~~~~~~~=C2=A0=C2=A0=C2=A0=C2=A0 ^
> /usr/src/contrib/bc/include/vm.h:437:6: note: 'bc_vm_putchar' declared =
here
> void bc_vm_putchar(int c, BcFlushType type);
> =C2=A0=C2=A0=C2=A0=C2=A0 ^
> /usr/src/contrib/bc/src/program.c:552:23: error: too few arguments to f=
unction
> call, expected 2, have 1
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bc_vm_putchar('\\');
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ~~~~~~~~~~~~~=C2=A0=C2=A0=C2=A0=C2=
=A0 ^
> /usr/src/contrib/bc/include/vm.h:437:6: note: 'bc_vm_putchar' declared =
here
> void bc_vm_putchar(int c, BcFlushType type);
> =C2=A0=C2=A0=C2=A0=C2=A0 ^
> /usr/src/contrib/bc/src/program.c:556:18: error: too few arguments to f=
unction
> call, expected 2, have 1
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 bc_vm_putchar(c);
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 ~~~~~~~~~~~~~=C2=A0 ^
> /usr/src/contrib/bc/include/vm.h:437:6: note: 'bc_vm_putchar' declared =
here
> void bc_vm_putchar(int c, BcFlushType type);
> =C2=A0=C2=A0=C2=A0=C2=A0 ^
> /usr/src/contrib/bc/src/program.c:601:25: error: too few arguments to f=
unction
> call, expected 2, have 1
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 bc_file_flush(&vm.fout);
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 ~~~~~~~~~~~~~=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 ^
> /usr/src/contrib/bc/include/file.h:76:6: note: 'bc_file_flush' declared=
 here
> void bc_file_flush(BcFile *restrict f, BcFlushType type);
> =C2=A0=C2=A0=C2=A0=C2=A0 ^
> /usr/src/contrib/bc/src/program.c:607:49: error: too few arguments to f=
unction
> call, expected 2, have 1
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (in=
st =3D=3D BC_INST_PRINT) bc_vm_putchar('\n');
> ~~~~~~~~~~~~~=C2=A0=C2=A0=C2=A0=C2=A0 ^
> /usr/src/contrib/bc/include/vm.h:437:6: note: 'bc_vm_putchar' declared =
here
> void bc_vm_putchar(int c, BcFlushType type);

All the other error messages do point at a mix of source files from befor=
e
and after introduction of the history feature, too ...

The line numbers in your version of program.c seem to be off, compared to=

the current sources, e.g. check out lines 609 and 610 on the above given =
URL
for the correct sources that correspond to that last error message.

Update your sources to a consistent state and your issue should be resolv=
ed.

Let me know if there are any further problems with this program.

Regards, STefan


--qyEW2c5IcNZqxQf8RRzU8filg0bBcsBSM--

--ZxpIzhU4EAkz3ZgzEZ0VPUodoVfT8OJvW
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAmDWuRUFAwAAAAAACgkQR+u171r99UQP
NQf/aayQFJoXSQfm/nkc/Nysq4FlYRClzBWn2UdJl9SzTZapcisj7ehuu6NrrofZJF21E2JBAudI
CsNUWOQYDDLdaf9E3rrcd2YApc39n643+W+mLP1iR+83YDwJ4e9X9+T4EQLIPZTzwTo636q8QxY7
yPW19/1n9Vu7mqzPPnjR9+LkqtNhuASRiukkVHj8Lr2sNpQPV6jfUUU4rrFjvhQGuMFufac5xYb4
AkutKPj5OZK1u9mZ1zrTXjT+B0/mdV9v6l+T6op4oXxtSQ0JA76JfiSaEoNwYhykCoZ16Xw50EUQ
70uCYE6Tm9+QR6BfiVsv2kuR/RQPvHKpkHmJ3mONIQ==
=yI07
-----END PGP SIGNATURE-----

--ZxpIzhU4EAkz3ZgzEZ0VPUodoVfT8OJvW--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a47bd978-e262-8d14-153e-20921e395c06>