From owner-freebsd-current@freebsd.org  Mon Jul 13 08:52:00 2015
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4A9763367
 for <freebsd-current@mailman.ysv.freebsd.org>;
 Mon, 13 Jul 2015 08:52:00 +0000 (UTC)
 (envelope-from okuno.kohji@jp.panasonic.com)
Received: from smtp.mei.co.jp (smtp.mei.co.jp [133.183.100.20])
 by mx1.freebsd.org (Postfix) with ESMTP id E6F0519AE;
 Mon, 13 Jul 2015 08:51:59 +0000 (UTC)
 (envelope-from okuno.kohji@jp.panasonic.com)
Received: from mail-gw.jp.panasonic.com ([157.8.1.157])
 by smtp.mei.co.jp (8.12.11.20060614/3.7W/kc-maile13) with ESMTP id
 t6D8piM5001791; Mon, 13 Jul 2015 17:51:44 +0900 (JST)
Received: from epochmail.jp.panasonic.com ([157.8.1.130])
 by mail.jp.panasonic.com (8.11.6p2/3.7W/kc-maili15) with ESMTP id t6D8phB30011;
 Mon, 13 Jul 2015 17:51:43 +0900
Received: by epochmail.jp.panasonic.com (8.12.11.20060308/3.7W/lomi14) id
 t6D8phAk006493; Mon, 13 Jul 2015 17:51:43 +0900
Received: from localhost
 by lomi14.jp.panasonic.com (8.12.11.20060308/3.7W) with ESMTP id
 t6D8pheq006461; Mon, 13 Jul 2015 17:51:43 +0900
Date: Mon, 13 Jul 2015 17:51:43 +0900 (JST)
Message-Id: <20150713.175143.290106286605820529.okuno.kohji@jp.panasonic.com>
To: hps@selasky.org
Cc: freebsd-current@freebsd.org, mav@FreeBSD.org, okuno.kohji@jp.panasonic.com
Subject: Re: Why shoud we cause panic in scsi_da.c?
From: Kohji Okuno <okuno.kohji@jp.panasonic.com>
In-Reply-To: <55A37933.3000802@selasky.org>
References: <20150709.150520.1823457260978955949.okuno.kohji@jp.panasonic.com>
 <20150713.171110.531869520391748650.okuno.kohji@jp.panasonic.com>
 <55A37933.3000802@selasky.org>
Organization: Panasonic Corporation
X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jul 2015 08:52:00 -0000

Hi HPS,

Thank you for your comment.
I will wait for the commnet.

Kohji Okuno

> On 07/13/15 10:11, Kohji Okuno wrote:
>> Hi,
>>
>> Could you comment on my quesion?
>>
>> Best regards,
>>   Kohji Okuno
>>
>>> Hi,
>>>
>>> I found panic() in scsi_da.c. Please find the following.
>>> I think we should return with error without panic().
>>> What do you think about this?
>>>
>>> scsi_da.c:
>>> 3018	                } else if (bp != NULL) {
>>> 3019 if ((done_ccb->ccb_h.status & CAM_DEV_QFRZN) != 0)
>>> 3020	                                panic("REQ_CMP with QFRZN");
>>>
> 
> Hi,
> 
> It looks to me more like an KASSERT() is appropriate here.
> 
> Might be some people which can answer this are on vacation currently.
> 
> --HPS
> 
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"