From owner-freebsd-ports-bugs@freebsd.org Fri Apr 27 16:49:16 2018 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 59C4CFACE31 for ; Fri, 27 Apr 2018 16:49:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id DF97B834F7 for ; Fri, 27 Apr 2018 16:49:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 9DA66FACE2E; Fri, 27 Apr 2018 16:49:15 +0000 (UTC) Delivered-To: ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7B6EAFACE2D for ; Fri, 27 Apr 2018 16:49:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 152C7834F1 for ; Fri, 27 Apr 2018 16:49:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 59C0923808 for ; Fri, 27 Apr 2018 16:49:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w3RGnEmN081307 for ; Fri, 27 Apr 2018 16:49:14 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w3RGnEVW081306 for ports-bugs@FreeBSD.org; Fri, 27 Apr 2018 16:49:14 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 227799] editors/emacs editors/emacs-devel: Add devel/liblockfile to LIB_DEPENDS Date: Fri, 27 Apr 2018 16:49:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jrm@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 16:49:16 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D227799 Joseph Mingrone changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrm@freebsd.org --- Comment #1 from Joseph Mingrone --- - This does not cause a build error in poudriere, but if LIB_DEPENDS=3Dliblockfile.so:devel/liblockfile is temporarily added, movema= il does indeed link to liblockfile.so.1, regardless what the MAILUTILS option = is set to. - Also adding ac_cv_lib_lockfile_maillock=3Dno to CONFIGURE_ENV prevents mo= vemail from linking to liblockfile.so.1. The important questions: Is liblockfile required for us? configure.ac contains these two blocks, so I would guess we do not, but am = far from clear. dnl Debian, at least: AC_CHECK_LIB(lockfile, maillock, have_lockfile=3Dyes, have_lockfile=3Dno) if test $have_lockfile =3D yes; then LIBS_MAIL=3D-llockfile AC_DEFINE(HAVE_LIBLOCKFILE, 1, [Define to 1 if you have the 'lockfile' library (-llockfile).]) else # If we have the shared liblockfile, assume we must use it for mail # locking (e.g. Debian). If we couldn't link against liblockfile # (no liblockfile.a installed), ensure that we don't need to. dnl This works for files generally, not just executables. dnl Should we look elsewhere for it? Maybe examine /etc/ld.so.conf? AC_CHECK_PROG(liblockfile, liblockfile.so, yes, no, /usr/lib:/lib:/usr/local/lib:$LD_LIBRARY_PATH) if test $ac_cv_prog_liblockfile =3D yes; then AC_MSG_ERROR([Shared liblockfile found but can't link against it. This probably means that movemail could lose mail. There may be a 'development' package to install containing liblockfile.]) fi fi AC_CHECK_HEADERS_ONCE(maillock.h) AC_SUBST(LIBS_MAIL) ------------ mail_lock=3Dno case "$opsys" in aix4-2) mail_lock=3D"lockf" ;; gnu|freebsd|dragonfly|netbsd|openbsd|darwin|irix6-5) mail_lock=3D"flock" = ;; ## On GNU/Linux systems, both methods are used by various mail programs. ## I assume most people are using newer mailers that have heard of flock. ## Change this if you need to. ## Debian contains a patch which says: "On Debian/GNU/Linux systems, ## configure gets the right answers, and that means *NOT* using flock. ## Using flock is guaranteed to be the wrong thing. See Debian Policy ## for details." and then uses '#ifdef DEBIAN'. Unfortunately the ## Debian maintainer hasn't provided a clean fix for Emacs. ## movemail.c will use 'maillock' when MAILDIR, HAVE_LIBMAIL and ## HAVE_MAILLOCK_H are defined, so the following appears to be the ## correct logic. -- fx ## We must check for HAVE_LIBLOCKFILE too, as movemail does. ## liblockfile is a Free Software replacement for libmail, used on ## Debian systems and elsewhere. -rfr. gnu-*) mail_lock=3D"flock" if test $have_mail =3D yes || test $have_lockfile =3D yes; then test $ac_cv_header_maillock_h =3D yes && mail_lock=3Dno fi ;; --=20 You are receiving this mail because: You are the assignee for the bug.=