Date: Tue, 16 Jul 2024 13:58:26 +0200 From: Michael Gmelin <grembo@freebsd.org> To: Zsolt Udvari <uzsolt@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d6a461ce6716 - main - games/lolcat: update to 1.5 Message-ID: <20C8F444-FC44-4FC5-8871-D5DF64549C7E@freebsd.org> In-Reply-To: <ZpZdrlZ9OC_zUFqs@bsd-zsolt> References: <ZpZdrlZ9OC_zUFqs@bsd-zsolt>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 16. Jul 2024, at 13:47, Zsolt Udvari <uzsolt@freebsd.org> wrote: >=20 > =EF=BB=BFOn Tue, Jul 16, 2024 at 08:08:19AM +0000, Alexey Dokuchaev wrote:= >> PLIST_FILES are handy when there's few of them so it's easier to >> keep all things in one place (the Makefile), also makes the diffs >> shorter. Another good thing is that they are part of the options >> helpers, so one can list one or more FOO_PLIST_FILES_[OFF] while >> leaving the main pkg-plist less cluttered (no need for PLIST_SUBs). > I'm not sure "keep all things in one place" is the most important. I > prefer store everything in its own place and don't mix them, even if the > diffs is longer a bit. > Cluttered because of PLIST_SUB: yes, it's very ugly, many-many > percent sign (I hate too). One possible solution: split the pkg-plist > and the conditional parts go into separate files (e.g. pkg-plist.docs > contains the documentations, without PLIST_SUB-like prefixes). >=20 > It's only a beginner committer's opinion, I accept the established > habits. The approach we have is based on common sense - use separate files if benefi= ciary, if it=E2=80=99s only a few entries, you might keep keep it in the Mak= efile (portlint also has some recommendations about it). The ports tree is h= uge as it is, adding lots of tiny files doesn=E2=80=99t help. For some ports= using automatic plists makes sense too, it really depends on the port in qu= estion. -m
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20C8F444-FC44-4FC5-8871-D5DF64549C7E>