From owner-svn-ports-all@freebsd.org Mon Nov 5 06:01:33 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7DBAA10F9227; Mon, 5 Nov 2018 06:01:33 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0CFA870BD4; Mon, 5 Nov 2018 06:01:33 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id EE86E18C63; Mon, 5 Nov 2018 06:01:32 +0000 (UTC) Date: Mon, 5 Nov 2018 06:01:32 +0000 From: Alexey Dokuchaev To: Mark Linimon Cc: Rene Ladan , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r484041 - head/devel/heimdall Message-ID: <20181105060132.GA4050@FreeBSD.org> References: <201811041345.wA4DjCGN025777@repo.freebsd.org> <20181104151315.GA61162@FreeBSD.org> <20181104172918.GA21261@lonesome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181104172918.GA21261@lonesome.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 0CFA870BD4 X-Spamd-Result: default: False [-5.39 / 200.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.99)[-0.994,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; R_SPF_SOFTFAIL(0.00)[~all]; RCPT_COUNT_FIVE(0.00)[5]; IP_SCORE(-3.32)[ip: (-8.71), ipnet: 96.47.64.0/20(-4.34), asn: 11403(-3.48), country: US(-0.06)]; MX_GOOD(-0.01)[cached: mx66.freebsd.org]; NEURAL_HAM_SHORT(-0.97)[-0.968,0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Nov 2018 06:01:33 -0000 On Sun, Nov 04, 2018 at 05:29:18PM +0000, Mark Linimon wrote: > On Sun, Nov 04, 2018 at 03:13:15PM +0000, Alexey Dokuchaev wrote: > > I don't understand, why not just fix the code by removing offending part: > > portsjail% grep -v "#" ../analysis/clang6_regressions.work | wc -l > 261 > > Fixing 261 ports is more than one person can do IMVVHO. Okay, but I'm talking about one particular port (which is maintained, so one might expect that maintainer has some knowledge of the code) and I've attached a patch. I believe it is quite doable by one person in this very case. :-) ./danfe