Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 8 Aug 2002 06:35:37 -0700 (PDT)
From:      Jens Rehsack <rehsack@liwing.de>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/41447: Sablot 0.95 exports constants
Message-ID:  <200208081335.g78DZbjr034286@www.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         41447
>Category:       ports
>Synopsis:       Sablot 0.95 exports constants
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 08 06:40:01 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Jens Rehsack
>Release:        4.6-STABLE
>Organization:
LiWing IT-Services
>Environment:
>Description:
The actualized sablot-port exports in sxpath.h some global constants.
This lacks C/C++ conventions who say it should be declared as
x.h:
const long int x;
x.c
const long int x = a;

This multiple export bugs if the header will included multiple times into object files of a library.
This happens in php4 - what causes my (wrong!) PR/41405.
>How-To-Repeat:
Build PHP4 with Sablot 0.95
>Fix:
--- src/engine/sxpath.h.orig	Thu Aug  8 12:59:11 2002
+++ src/engine/sxpath.h		Thu Aug  8 12:59:52 2002
@@ -66,9 +66,9 @@
 typedef void *QueryContext;
 
 /*option constants */
-const unsigned long SXPF_DISPOSE_NAMES = 1;
-const unsigned long SXPF_DISPOSE_VALUES = 2;
-const unsigned long SXPF_SUPPORTS_UNPARSED_ENTITIES = 4;
+#define SXPF_DISPOSE_NAMES 1
+#define SXPF_DISPOSE_VALUES 2
+#define SXPF_SUPPORTS_UNPARSED_ENTITIES 4
 
 /*
  *    DOM handler functions
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200208081335.g78DZbjr034286>