From owner-freebsd-fortran@FreeBSD.ORG Mon Jan 26 10:19:24 2015 Return-Path: Delivered-To: fortran@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7F2D4DB2; Mon, 26 Jan 2015 10:19:24 +0000 (UTC) Received: from mailrelay113.isp.belgacom.be (mailrelay113.isp.belgacom.be [195.238.20.140]) by mx1.freebsd.org (Postfix) with ESMTP id E3BD0BD8; Mon, 26 Jan 2015 10:19:23 +0000 (UTC) X-Belgacom-Dynamic: yes X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=r3/LV5qEOeRNqOlObU3fPeZ+G8vFrxRTI9UozocECbw= c=1 sm=2 a=kj9zAlcOel0A:10 a=KFzSvIWE-yI3Gy1VC7QA:9 a=CjuIK1q_8ugA:10 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AuYGADwTxlRbsIcT/2dsb2JhbABagwZSWcY3hXkCgRJEAQEBAQF9hA0BBScTHCMQCxgJJQ8qHgaIQwHSVAEBAQEBBQEBAQEej3gHhCkBBJI5hVWBTJBxIoNvPTGCQgEBAQ Received: from 19.135-176-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.176.135.19]) by relay.skynet.be with ESMTP; 26 Jan 2015 11:18:12 +0100 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.9/8.14.9) with ESMTP id t0QAIBaw001530; Mon, 26 Jan 2015 11:18:11 +0100 (CET) (envelope-from tijl@FreeBSD.org) Date: Mon, 26 Jan 2015 11:18:10 +0100 From: Tijl Coosemans To: Gerald Pfeifer Subject: Re: Avoid hardcoding of the version in lang/gcc in Uses/fortran.mk (PING) Message-ID: <20150126111810.0b4befa8@kalimero.tijl.coosemans.org> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Antoine Brodin , fortran@freebsd.org X-BeenThere: freebsd-fortran@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Fortran on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jan 2015 10:19:24 -0000 On Mon, 26 Jan 2015 01:04:40 +0100 (CET) Gerald Pfeifer wrote: > On Sunday 2015-01-25 22:14, Antoine Brodin wrote: >> I didn't test but this looks ok. >> I think the LANG_GCC_IS assignement can be moved before the .endif > > Yes, this is a good point! I made this change before committing > the patch. I'm not going to ask for this patch to be backed out, but I do want it to be noted (again) that I disagree with the way lang/gcc* is organised. The only reason for this change is because the gcc ports are fighting the default-versions mechanism instead of conforming to it and no good explanation has been given for why they should be allowed to do so. This patch is a hack. None of the other ports that use default-versions need it. In my opinion one of the lang/gccXY ports has to become the default instead of lang/gcc. That's how default-versions works. lang/gcc can stay as a meta-port with a RUN_DEPENDS on the default lang/gccXY, similar to lang/python. This way "pkg add gcc" still works. And just like lang/python, lang/gcc could install symlinks like gcc -> gccXY, g++ -> g++XY,... which would be really convenient now that /usr/bin/gcc is gone. This patch would not be necessary then because the .if in fortran.mk would disappear (what's currently in the .else branch would be all that's needed). A similar .if in bsd.gcc.mk would disappear as well, along with the LANG_GCC_IS variable.